From: Vladimir 'phcoder' Serbinenko <phcoder@gmail.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] turn grub-emu into a port
Date: Sat, 31 Oct 2009 00:08:55 +0100 [thread overview]
Message-ID: <4AEB7207.9060009@gmail.com> (raw)
In-Reply-To: <20091026181010.GA22942@thorin>
Robert Millan wrote:
> This turns grub-emu into a port in order to make it easier to port GRUB to
> new CPUs. A porter can then do the CPU port without having to worry about
> firmware and/or hardware drivers initially.
>
> Patch attached. Branch is available in
> bzr+ssh://bzr.savannah.gnu.org/grub/people/robertmh/grub-emu/
>
>
Following hunk is a regression for me:
- return (tv.tv_sec * GRUB_TICKS_PER_SECOND
- + (((tv.tv_sec % GRUB_TICKS_PER_SECOND) * 1000000 + tv.tv_usec)
- * GRUB_TICKS_PER_SECOND / 1000000));
+ GRUB_COMPILE_TIME_ASSERT (GRUB_TICKS_PER_SECOND == 1000000);
+ return (tv.tv_sec * 1000000 + tv.tv_usec);
Having virtual clock going at any rate is an advantage for debugging.
Other than this I'm ok with this patch and you can merge it into
experimental
> ------------------------------------------------------------------------
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
--
Regards
Vladimir 'phcoder' Serbinenko
Personal git repository: http://repo.or.cz/w/grub2/phcoder.git
next prev parent reply other threads:[~2009-10-30 23:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 18:10 [PATCH] turn grub-emu into a port Robert Millan
2009-10-30 22:49 ` Robert Millan
2009-10-30 23:08 ` Vladimir 'phcoder' Serbinenko [this message]
2009-10-31 10:06 ` Robert Millan
2009-10-31 10:18 ` Vladimir 'phcoder' Serbinenko
2009-10-31 10:29 ` Robert Millan
2009-11-09 22:50 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AEB7207.9060009@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.