All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: netdev@vger.kernel.org,
	virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, mingo@elte.hu, linux-mm@kvack.org,
	akpm@linux-foundation.org
Subject: Re: [PATCHv7 3/3] vhost_net: a kernel-level virtio server
Date: Wed, 4 Nov 2009 15:08:28 +0200	[thread overview]
Message-ID: <20091104130828.GC8920@redhat.com> (raw)
In-Reply-To: <20091104125957.GL31511@one.firstfloor.org>

On Wed, Nov 04, 2009 at 01:59:57PM +0100, Andi Kleen wrote:
> > Fine?
> 
> I cannot say -- are there paths that could drop the device beforehand?

Do you mean drop the mm reference?

> (as in do you hold a reference to it?)

By design I think I always have a reference to mm before I use it.

This works like this:
ioctl SET_OWNER - calls get_task_mm, I think this gets a reference to mm
ioctl SET_BACKEND - checks that SET_OWNER was run, starts virtqueue
ioctl RESET_OWNER - stops virtqueues, drops the reference to mm
file close - stops virtqueues, if we still have it then drops mm

This is why I think I can call use_mm/unuse_mm while virtqueue is running,
safely.
Makes sense?

> -Andi
> -- 
> ak@linux.intel.com -- Speaking for myself only.

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: netdev@vger.kernel.org,
	virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, mingo@elte.hu, linux-mm@kvack.org,
	akpm@linux-foundation.org
Subject: Re: [PATCHv7 3/3] vhost_net: a kernel-level virtio server
Date: Wed, 4 Nov 2009 15:08:28 +0200	[thread overview]
Message-ID: <20091104130828.GC8920@redhat.com> (raw)
In-Reply-To: <20091104125957.GL31511@one.firstfloor.org>

On Wed, Nov 04, 2009 at 01:59:57PM +0100, Andi Kleen wrote:
> > Fine?
> 
> I cannot say -- are there paths that could drop the device beforehand?

Do you mean drop the mm reference?

> (as in do you hold a reference to it?)

By design I think I always have a reference to mm before I use it.

This works like this:
ioctl SET_OWNER - calls get_task_mm, I think this gets a reference to mm
ioctl SET_BACKEND - checks that SET_OWNER was run, starts virtqueue
ioctl RESET_OWNER - stops virtqueues, drops the reference to mm
file close - stops virtqueues, if we still have it then drops mm

This is why I think I can call use_mm/unuse_mm while virtqueue is running,
safely.
Makes sense?

> -Andi
> -- 
> ak@linux.intel.com -- Speaking for myself only.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-11-04 13:11 UTC|newest]

Thread overview: 107+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1257267892.git.mst@redhat.com>
2009-11-03 17:24 ` [PATCHv7 1/3] tun: export underlying socket Michael S. Tsirkin
2009-11-03 17:24 ` Michael S. Tsirkin
2009-11-03 17:24   ` Michael S. Tsirkin
2009-11-03 17:24   ` Michael S. Tsirkin
2009-11-04 13:30   ` David Miller
2009-11-04 13:30   ` David Miller
2009-11-04 13:30     ` David Miller
2009-11-03 17:24 ` [PATCHv7 2/3] mm: export use_mm/unuse_mm to modules Michael S. Tsirkin
2009-11-03 17:24 ` Michael S. Tsirkin
2009-11-03 17:24   ` Michael S. Tsirkin
2009-11-03 17:24   ` Michael S. Tsirkin
2009-11-03 17:32   ` Gregory Haskins
2009-11-03 17:32   ` Gregory Haskins
2009-11-03 17:24 ` [PATCHv7 3/3] vhost_net: a kernel-level virtio server Michael S. Tsirkin
2009-11-03 17:24 ` Michael S. Tsirkin
2009-11-03 17:24   ` Michael S. Tsirkin
2009-11-03 17:24   ` Michael S. Tsirkin
2009-11-03 18:03   ` Eric Dumazet
2009-11-03 18:03   ` Eric Dumazet
2009-11-03 18:03     ` Eric Dumazet
2009-11-03 18:03     ` Eric Dumazet
2009-11-03 18:08     ` Gregory Haskins
2009-11-03 18:08     ` Gregory Haskins
2009-11-03 18:14       ` Gregory Haskins
2009-11-03 18:14       ` Gregory Haskins
2009-11-03 18:51         ` Eric Dumazet
2009-11-03 18:51           ` Eric Dumazet
2009-11-03 18:51           ` Eric Dumazet
2009-11-03 19:50           ` Gregory Haskins
2009-11-03 19:50           ` Gregory Haskins
2009-11-03 19:58           ` Michael S. Tsirkin
2009-11-03 19:58             ` Michael S. Tsirkin
2009-11-03 19:58             ` Michael S. Tsirkin
2009-11-03 21:11             ` Eric Dumazet
2009-11-03 21:11               ` Eric Dumazet
2009-11-03 21:11               ` Eric Dumazet
2009-11-04 12:04               ` Michael S. Tsirkin
2009-11-04 12:04                 ` Michael S. Tsirkin
2009-11-04 12:04                 ` Michael S. Tsirkin
2009-11-04 12:04               ` Michael S. Tsirkin
2009-11-03 21:11             ` Eric Dumazet
2009-11-03 19:58           ` Michael S. Tsirkin
2009-11-03 18:51         ` Eric Dumazet
2009-11-03 23:57         ` Paul E. McKenney
2009-11-03 23:57         ` Paul E. McKenney
2009-11-03 23:57           ` Paul E. McKenney
2009-11-03 23:57           ` Paul E. McKenney
2009-11-04 11:57           ` Michael S. Tsirkin
2009-11-04 11:57           ` Michael S. Tsirkin
2009-11-04 11:57             ` Michael S. Tsirkin
2009-11-04 11:57             ` Michael S. Tsirkin
2009-11-04 17:25             ` Paul E. McKenney
2009-11-04 17:25             ` Paul E. McKenney
2009-11-04 17:25               ` Paul E. McKenney
2009-11-04 17:25               ` Paul E. McKenney
2009-11-04 17:33               ` Eric Dumazet
2009-11-04 17:33               ` Eric Dumazet
2009-11-04 17:33                 ` Eric Dumazet
2009-11-04 17:33                 ` Eric Dumazet
2009-11-04 19:06               ` Michael S. Tsirkin
2009-11-04 19:06               ` Michael S. Tsirkin
2009-11-04 19:06                 ` Michael S. Tsirkin
2009-11-04 19:12                 ` Gregory Haskins
2009-11-04 19:12                 ` Gregory Haskins
2009-11-06  5:01               ` Rusty Russell
2009-11-06  5:01                 ` Rusty Russell
2009-11-06 16:30                 ` Paul E. McKenney
2009-11-06 16:30                   ` Paul E. McKenney
2009-11-08  4:09                   ` Rusty Russell
2009-11-08  4:09                   ` Rusty Russell
2009-11-08  4:09                     ` Rusty Russell
2009-11-08 19:36                     ` Paul E. McKenney
2009-11-08 19:36                       ` Paul E. McKenney
2009-11-08 19:36                     ` Paul E. McKenney
2009-11-06 16:30                 ` Paul E. McKenney
2009-11-06  5:01               ` Rusty Russell
2009-11-03 19:55     ` Michael S. Tsirkin
2009-11-03 19:55       ` Michael S. Tsirkin
2009-11-03 19:55       ` Michael S. Tsirkin
2009-11-03 19:55     ` Michael S. Tsirkin
2009-11-04 11:08   ` Andi Kleen
2009-11-04 11:08   ` Andi Kleen
2009-11-04 11:08     ` Andi Kleen
2009-11-04 12:10     ` Michael S. Tsirkin
2009-11-04 12:10     ` Michael S. Tsirkin
2009-11-04 12:10       ` Michael S. Tsirkin
2009-11-04 12:59       ` Andi Kleen
2009-11-04 12:59       ` Andi Kleen
2009-11-04 12:59         ` Andi Kleen
2009-11-04 13:08         ` Michael S. Tsirkin [this message]
2009-11-04 13:08           ` Michael S. Tsirkin
2009-11-04 13:15           ` Andi Kleen
2009-11-04 13:15             ` Andi Kleen
2009-11-04 13:17             ` Michael S. Tsirkin
2009-11-04 13:17             ` Michael S. Tsirkin
2009-11-04 13:17               ` Michael S. Tsirkin
2009-11-04 13:37               ` Andi Kleen
2009-11-04 13:37               ` Andi Kleen
2009-11-04 13:37                 ` Andi Kleen
2009-11-04 13:41                 ` Michael S. Tsirkin
2009-11-04 13:41                   ` Michael S. Tsirkin
2009-11-04 16:37                   ` Michael S. Tsirkin
2009-11-04 16:37                   ` Michael S. Tsirkin
2009-11-04 16:37                     ` Michael S. Tsirkin
2009-11-04 13:41                 ` Michael S. Tsirkin
2009-11-04 13:15           ` Andi Kleen
2009-11-04 13:08         ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091104130828.GC8920@redhat.com \
    --to=mst@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@elte.hu \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.