Re: [Qemu-devel] [PATCH 0/4] net-bridge: rootless bridge support for qemu

[Arnd Bergmann <arnd@arndb.de>]

On Saturday 07 November 2009, Anthony Liguori wrote:
> Avi Kivity wrote:
> > On 11/07/2009 11:14 AM, Avi Kivity wrote:
> >> I'd welcome -net bridge as one of them.  But we shouldn't try to 
> >> invent access control systems or install suid helpers.
> >
> > We can make the helper a script that does
> >
> >   exec sudo /the/real/helper "$@"
> >
> > so a user can add it to /etc/sudoers and get pre-authenticated 
> > configuration.
> 
> The key point of the helper here is that you pass an fd to a socketpair 
> and you then receive an fd over that socket.  What the helper does is 
> really less important.  Whether it's a script like you suggest or 
> something like I proposed doesn't matter from a qemu perspective.

Well, the difference matters from a security perspective. The sudo
script that Avi suggested just means that you can guarantee you don't
introduce any security holes through a suid executable. Fortunately,
it does not impact the contents of your helper either, only the
installation. You could even be clever in qemu and use call the helper
using sudo if qemu is running as unpriviledged user and the helper is
not a suid file.

	Arnd <><