All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Smith <lk-netdev@lk-netdev.nosense.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: virtualization@linux-foundation.com,
	Xu <herbert@gondor.apana.org.au>, Arnd Bergmann <arnd@arndb.de>,
	Fischer <anna.fischer@hp.com>,
	netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, Herbert,
	Gerhard Stenzel <gerhard.stenzel@de.ibm.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Jens Osterkamp <jens@linux.vnet.ibm.com>,
	Patrick Mullaney <pmullaney@novell.com>,
	Stephen Hemminger <shemminger@vyatta.com>,
	Edge Virtual Bridging <evb@yahoogroups.com>,
	David Miller <davem@davemloft.net>,
	Anna
Subject: Re: [Bridge] [PATCH 0/3] macvlan: add vepa and bridge mode
Date: Wed, 18 Nov 2009 19:31:16 +1030	[thread overview]
Message-ID: <20091118193116.76881dd9@opy.nosense.org> (raw)
In-Reply-To: <1258497551-25959-1-git-send-email-arnd@arndb.de>

On Tue, 17 Nov 2009 22:39:07 +0000
Arnd Bergmann <arnd@arndb.de> wrote:

> This is based on an earlier patch from Eric Biederman adding
> forwarding between macvlans. I extended his approach to
> allow the administrator to choose the mode for each macvlan,
> and to implement a functional VEPA between macvlan.
> 
> Still missing from this is support for communication between
> the lower device that the macvlans are based on. This would
> be extremely useful but as others have found out before me
> requires significant changes not only to macvlan but also
> to the common transmit path.

If this means that the "children" macvlans can't communicate with their
"parent" interface as though they were all attached to the same virtual
ethernet segment, I think that is a reasonable limitation. On other
networking equipment I've used, the moment "sub-interfaces"
are created, their parent interface can't be used for any
communications, only for setting link related parameters e.g. for
ethernet interfaces, speed and duplex etc.

> 
> I've seen one panic during testing this that I still need
> to track down, but it generally does what is advertised.
> I've tested VEPA operation with the hairpin support
> added to the bridge driver by Anna Fischer.
> 
> My current plan is to submit this for inclusion in 2.6.33
> when people are happy with it and I tracked down any
> remaining bugs, and possibly to do the communication with
> the lower device one release later.
> 
> 	Arnd <><
> 
> ---
> 
> Arnd Bergmann (3):
>   macvlan: implement VEPA and private mode
>   macvlan: export macvlan mode through netlink
>   iplink: add macvlan options for bridge mode
> 
> Eric Biederman (1):
>   macvlan: Reflect macvlan packets meant for other macvlan devices
> 
>  linux/drivers/net/macvlan.c   |  170 +++++++++++++++++++++++++++++++++-----
>  linux/include/linux/if_link.h |   15 +++
>  2 files changed, 161 insertions(+), 24 deletions(-)
> 
>  iproute2/include/linux/if_link.h |   15 +++
>  iproute2/ip/Makefile             |    3 +-
>  iproute2/ip/iplink_macvlan.c     |   93 ++++++++++++++++++
>  3 files changed, 110 insertions(+), 1 deletions(-)
>  create mode 100644 ip/iplink_macvlan.c
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Mark Smith <lk-netdev@lk-netdev.nosense.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	David Miller <davem@davemloft.net>,
	Stephen Hemminger <shemminger@vyatta.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Patrick McHardy <kaber@trash.net>,
	Patrick Mullaney <pmullaney@novell.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Edge Virtual Bridging <evb@yahoogroups.com>,
	Anna Fischer <anna.fischer@hp.com>,
	bridge@lists.linux-foundation.org,
	virtualization@linux-foundation.com,
	Jens Osterkamp <jens@linux.vnet.ibm.com>,
	Gerhard Stenzel <gerhard.stenzel@de.ibm.com>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 0/3] macvlan: add vepa and bridge mode
Date: Wed, 18 Nov 2009 19:31:16 +1030	[thread overview]
Message-ID: <20091118193116.76881dd9@opy.nosense.org> (raw)
In-Reply-To: <1258497551-25959-1-git-send-email-arnd@arndb.de>

On Tue, 17 Nov 2009 22:39:07 +0000
Arnd Bergmann <arnd@arndb.de> wrote:

> This is based on an earlier patch from Eric Biederman adding
> forwarding between macvlans. I extended his approach to
> allow the administrator to choose the mode for each macvlan,
> and to implement a functional VEPA between macvlan.
> 
> Still missing from this is support for communication between
> the lower device that the macvlans are based on. This would
> be extremely useful but as others have found out before me
> requires significant changes not only to macvlan but also
> to the common transmit path.

If this means that the "children" macvlans can't communicate with their
"parent" interface as though they were all attached to the same virtual
ethernet segment, I think that is a reasonable limitation. On other
networking equipment I've used, the moment "sub-interfaces"
are created, their parent interface can't be used for any
communications, only for setting link related parameters e.g. for
ethernet interfaces, speed and duplex etc.

> 
> I've seen one panic during testing this that I still need
> to track down, but it generally does what is advertised.
> I've tested VEPA operation with the hairpin support
> added to the bridge driver by Anna Fischer.
> 
> My current plan is to submit this for inclusion in 2.6.33
> when people are happy with it and I tracked down any
> remaining bugs, and possibly to do the communication with
> the lower device one release later.
> 
> 	Arnd <><
> 
> ---
> 
> Arnd Bergmann (3):
>   macvlan: implement VEPA and private mode
>   macvlan: export macvlan mode through netlink
>   iplink: add macvlan options for bridge mode
> 
> Eric Biederman (1):
>   macvlan: Reflect macvlan packets meant for other macvlan devices
> 
>  linux/drivers/net/macvlan.c   |  170 +++++++++++++++++++++++++++++++++-----
>  linux/include/linux/if_link.h |   15 +++
>  2 files changed, 161 insertions(+), 24 deletions(-)
> 
>  iproute2/include/linux/if_link.h |   15 +++
>  iproute2/ip/Makefile             |    3 +-
>  iproute2/ip/iplink_macvlan.c     |   93 ++++++++++++++++++
>  3 files changed, 110 insertions(+), 1 deletions(-)
>  create mode 100644 ip/iplink_macvlan.c
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2009-11-18  9:01 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-17 22:39 [Bridge] [PATCH 0/3] macvlan: add vepa and bridge mode Arnd Bergmann
2009-11-17 22:39 ` Arnd Bergmann
2009-11-17 22:39 ` [Bridge] [PATCH 1/3] macvlan: Reflect macvlan packets meant for other macvlan devices Arnd Bergmann
2009-11-17 22:39   ` Arnd Bergmann
2009-11-18  6:30   ` [Bridge] " Eric Dumazet
2009-11-18  6:30     ` Eric Dumazet
2009-11-18  9:47     ` [Bridge] " Arnd Bergmann
2009-11-18  9:47       ` Arnd Bergmann
2009-11-18 14:37       ` [Bridge] " Eric W. Biederman
2009-11-18 14:37         ` Eric W. Biederman
2009-11-18 14:44         ` Arnd Bergmann
2009-11-18 14:44         ` [Bridge] " Arnd Bergmann
2009-11-18 14:44           ` Arnd Bergmann
2009-11-18 23:32         ` [Bridge] " Arnd Bergmann
2009-11-18 23:32           ` Arnd Bergmann
2009-11-18 23:55           ` [Bridge] " Eric W. Biederman
2009-11-18 23:55             ` Eric W. Biederman
2009-11-19 11:44             ` [Bridge] " Arnd Bergmann
2009-11-19 11:44               ` Arnd Bergmann
2009-11-19 14:47               ` [Bridge] " Patrick McHardy
2009-11-19 14:47                 ` Patrick McHardy
2009-11-18 10:00   ` [Bridge] " roel kluin
2009-11-18 10:00     ` roel kluin
2009-11-18 10:00     ` roel kluin
2009-11-17 22:39 ` [Bridge] [PATCH 2/3] macvlan: implement VEPA and private mode Arnd Bergmann
2009-11-17 22:39   ` Arnd Bergmann
2009-11-18  6:42   ` [Bridge] " Eric Dumazet
2009-11-18  6:42     ` Eric Dumazet
2009-11-18  9:48     ` [Bridge] " Arnd Bergmann
2009-11-18  9:48       ` Arnd Bergmann
2009-11-17 22:39 ` [Bridge] [PATCH 3/3] macvlan: export macvlan mode through netlink Arnd Bergmann
2009-11-17 22:39   ` Arnd Bergmann
2009-11-18  6:48   ` [Bridge] " Eric Dumazet
2009-11-18  6:48     ` Eric Dumazet
2009-11-18  9:59     ` Arnd Bergmann
2009-11-18  9:59     ` [Bridge] " Arnd Bergmann
2009-11-18  9:59       ` Arnd Bergmann
2009-11-19 14:38       ` [Bridge] " Patrick McHardy
2009-11-19 14:38         ` Patrick McHardy
2009-11-19 14:47         ` [Bridge] " Arnd Bergmann
2009-11-19 14:47           ` Arnd Bergmann
2009-11-19 14:47         ` Arnd Bergmann
2009-11-19 14:38       ` Patrick McHardy
2009-11-17 22:39 ` [Bridge] [PATCH] iplink: add macvlan options for bridge mode Arnd Bergmann
2009-11-17 22:39   ` Arnd Bergmann
2009-12-18 13:45   ` [Bridge] " Arnd Bergmann
2009-12-18 13:45     ` Arnd Bergmann
2009-12-18 17:25     ` [Bridge] " Stephen Hemminger
2009-12-18 17:25       ` Stephen Hemminger
2009-12-18 17:37       ` [Bridge] " Arnd Bergmann
2009-12-18 17:37         ` Arnd Bergmann
2009-11-17 22:56 ` [PATCH 0/3] macvlan: add vepa and " Arnd Bergmann
2009-11-17 22:56 ` [Bridge] " Arnd Bergmann
2009-11-17 22:56   ` Arnd Bergmann
2009-11-18  9:01 ` Mark Smith [this message]
2009-11-18  9:01   ` Mark Smith
2009-11-27 10:57 ` [Bridge] [PATCH, resend] iproute2/iplink: add macvlan options for " Arnd Bergmann
2009-11-27 10:57   ` Arnd Bergmann
2009-12-26 19:24   ` [Bridge] " Stephen Hemminger
2009-12-26 19:24     ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091118193116.76881dd9@opy.nosense.org \
    --to=lk-netdev@lk-netdev.nosense.org \
    --cc=anna.fischer@hp.com \
    --cc=arnd@arndb.de \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=evb@yahoogroups.com \
    --cc=gerhard.stenzel@de.ibm.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jens@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pmullaney@novell.com \
    --cc=shemminger@vyatta.com \
    --cc=virtualization@linux-foundation.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.