From: Patrick McHardy <kaber@trash.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: virtualization@linux-foundation.com,
Herbert Xu <herbert@gondor.apana.org.au>,
Eric Dumazet <eric.dumazet@gmail.com>,
Anna Fischer <anna.fischer@hp.com>,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
linux-kernel@vger.kernel.org,
Gerhard Stenzel <gerhard.stenzel@de.ibm.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Jens Osterkamp <jens@linux.vnet.ibm.com>,
Patrick Mullaney <pmullaney@novell.com>,
Stephen Hemminger <shemminger@vyatta.com>,
Edge Virtual Bridging <evb@yahoogroups.com>,
David Miller <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH 1/3] macvlan: Reflect macvlan packets meant for other macvlan devices
Date: Thu, 19 Nov 2009 15:47:55 +0100 [thread overview]
Message-ID: <4B055A9B.1090502@trash.net> (raw)
In-Reply-To: <200911191244.43916.arnd@arndb.de>
Arnd Bergmann wrote:
> On Thursday 19 November 2009, Eric W. Biederman wrote:
>>> It seems that we should never drop dst then. We either forward the frame to
>>> netif_rx or to dev_queue_xmit, and from how I read it now, we want to keep
>>> the dst in both cases.
>> When we loop back on our selves we certainly need to have dst clear because
>> we don't know how to cache routes through multiple network namespaces.
>
> Ah, right. So should I add the explicit dst_drop to the new dev_forward_skb()
> then? The veth driver doesn't need it, but it also looks like it won't hurt.
Yes, I think that should be fine.
WARNING: multiple messages have this Message-ID (diff)
From: Patrick McHardy <kaber@trash.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
David Miller <davem@davemloft.net>,
Stephen Hemminger <shemminger@vyatta.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Patrick Mullaney <pmullaney@novell.com>,
Edge Virtual Bridging <evb@yahoogroups.com>,
Anna Fischer <anna.fischer@hp.com>,
bridge@lists.linux-foundation.org,
virtualization@linux-foundation.com,
Jens Osterkamp <jens@linux.vnet.ibm.com>,
Gerhard Stenzel <gerhard.stenzel@de.ibm.com>
Subject: Re: [PATCH 1/3] macvlan: Reflect macvlan packets meant for other macvlan devices
Date: Thu, 19 Nov 2009 15:47:55 +0100 [thread overview]
Message-ID: <4B055A9B.1090502@trash.net> (raw)
In-Reply-To: <200911191244.43916.arnd@arndb.de>
Arnd Bergmann wrote:
> On Thursday 19 November 2009, Eric W. Biederman wrote:
>>> It seems that we should never drop dst then. We either forward the frame to
>>> netif_rx or to dev_queue_xmit, and from how I read it now, we want to keep
>>> the dst in both cases.
>> When we loop back on our selves we certainly need to have dst clear because
>> we don't know how to cache routes through multiple network namespaces.
>
> Ah, right. So should I add the explicit dst_drop to the new dev_forward_skb()
> then? The veth driver doesn't need it, but it also looks like it won't hurt.
Yes, I think that should be fine.
next prev parent reply other threads:[~2009-11-19 14:47 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 22:39 [Bridge] [PATCH 0/3] macvlan: add vepa and bridge mode Arnd Bergmann
2009-11-17 22:39 ` Arnd Bergmann
2009-11-17 22:39 ` [Bridge] [PATCH 1/3] macvlan: Reflect macvlan packets meant for other macvlan devices Arnd Bergmann
2009-11-17 22:39 ` Arnd Bergmann
2009-11-18 6:30 ` [Bridge] " Eric Dumazet
2009-11-18 6:30 ` Eric Dumazet
2009-11-18 9:47 ` [Bridge] " Arnd Bergmann
2009-11-18 9:47 ` Arnd Bergmann
2009-11-18 14:37 ` [Bridge] " Eric W. Biederman
2009-11-18 14:37 ` Eric W. Biederman
2009-11-18 14:44 ` [Bridge] " Arnd Bergmann
2009-11-18 14:44 ` Arnd Bergmann
2009-11-18 14:44 ` Arnd Bergmann
2009-11-18 23:32 ` [Bridge] " Arnd Bergmann
2009-11-18 23:32 ` Arnd Bergmann
2009-11-18 23:55 ` [Bridge] " Eric W. Biederman
2009-11-18 23:55 ` Eric W. Biederman
2009-11-19 11:44 ` [Bridge] " Arnd Bergmann
2009-11-19 11:44 ` Arnd Bergmann
2009-11-19 14:47 ` Patrick McHardy [this message]
2009-11-19 14:47 ` Patrick McHardy
2009-11-18 10:00 ` [Bridge] " roel kluin
2009-11-18 10:00 ` roel kluin
2009-11-18 10:00 ` roel kluin
2009-11-17 22:39 ` [Bridge] [PATCH 2/3] macvlan: implement VEPA and private mode Arnd Bergmann
2009-11-17 22:39 ` Arnd Bergmann
2009-11-18 6:42 ` [Bridge] " Eric Dumazet
2009-11-18 6:42 ` Eric Dumazet
2009-11-18 9:48 ` [Bridge] " Arnd Bergmann
2009-11-18 9:48 ` Arnd Bergmann
2009-11-17 22:39 ` [Bridge] [PATCH 3/3] macvlan: export macvlan mode through netlink Arnd Bergmann
2009-11-17 22:39 ` Arnd Bergmann
2009-11-18 6:48 ` [Bridge] " Eric Dumazet
2009-11-18 6:48 ` Eric Dumazet
2009-11-18 9:59 ` Arnd Bergmann
2009-11-18 9:59 ` [Bridge] " Arnd Bergmann
2009-11-18 9:59 ` Arnd Bergmann
2009-11-19 14:38 ` [Bridge] " Patrick McHardy
2009-11-19 14:38 ` Patrick McHardy
2009-11-19 14:47 ` [Bridge] " Arnd Bergmann
2009-11-19 14:47 ` Arnd Bergmann
2009-11-19 14:47 ` Arnd Bergmann
2009-11-19 14:38 ` Patrick McHardy
2009-11-17 22:39 ` [Bridge] [PATCH] iplink: add macvlan options for bridge mode Arnd Bergmann
2009-11-17 22:39 ` Arnd Bergmann
2009-12-18 13:45 ` [Bridge] " Arnd Bergmann
2009-12-18 13:45 ` Arnd Bergmann
2009-12-18 17:25 ` [Bridge] " Stephen Hemminger
2009-12-18 17:25 ` Stephen Hemminger
2009-12-18 17:37 ` [Bridge] " Arnd Bergmann
2009-12-18 17:37 ` Arnd Bergmann
2009-11-17 22:56 ` [PATCH 0/3] macvlan: add vepa and " Arnd Bergmann
2009-11-17 22:56 ` [Bridge] " Arnd Bergmann
2009-11-17 22:56 ` Arnd Bergmann
2009-11-18 9:01 ` [Bridge] " Mark Smith
2009-11-18 9:01 ` Mark Smith
2009-11-27 10:57 ` [Bridge] [PATCH, resend] iproute2/iplink: add macvlan options for " Arnd Bergmann
2009-11-27 10:57 ` Arnd Bergmann
2009-12-26 19:24 ` [Bridge] " Stephen Hemminger
2009-12-26 19:24 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B055A9B.1090502@trash.net \
--to=kaber@trash.net \
--cc=anna.fischer@hp.com \
--cc=arnd@arndb.de \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=evb@yahoogroups.com \
--cc=gerhard.stenzel@de.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=jens@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pmullaney@novell.com \
--cc=shemminger@vyatta.com \
--cc=virtualization@linux-foundation.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.