Re: [PATCH] b43: Rewrite DMA Tx status handling sanity checks

[Michael Buesch <mb@bu3sch.de>]

On Sunday 22 November 2009 19:11:52 Larry Finger wrote:
> On 11/22/2009 11:52 AM, Michael Buesch wrote:
> > On Thursday 19 November 2009 22:24:29 Michael Buesch wrote:
> >> This rewrites the error handling policies in the TX status handler.
> >> It tries to be error-tolerant as in "try hard to not crash the machine".
> >> It won't recover from errors (that are bugs in the firmware or driver),
> >> because that's impossible. However, it will return a more or less useful
> >> error message and bail out. It also tries hard to use rate-limited messages
> >> to not flood the syslog in case of a failure.
> >>
> >> Signed-off-by: Michael Buesch <mb@bu3sch.de>
> > 
> > So did somebody try this with opensource firmware, yet?
> 
> I'm testing now. So far, it has survived about 18 hours running tcpperf in one
> console, and a flood ping in another.

Cool. Thanks for testing. I'd have expected it to blow up, though. It's a little bit
strange, because there still are reports of blowing up opensource firmware. This patch
should produce better error messages in that case (it will not fix the blown firmware).

> It looks really good, but I want at least 
> 24 hours before committing.

Well, no. Just commit it, please. If this breaks, the _firmware_ has to be fixed.
Not the patch.

-- 
Greetings, Michael.