From: Larry Finger <Larry.Finger@lwfinger.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: "John W. Linville" <linville@tuxdriver.com>,
bcm43xx-dev@lists.berlios.de,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] b43: Rewrite DMA Tx status handling sanity checks
Date: Sun, 22 Nov 2009 19:34:09 -0600 [thread overview]
Message-ID: <4B09E691.8020205@lwfinger.net> (raw)
In-Reply-To: <200911192224.29491.mb@bu3sch.de>
On 11/19/2009 03:24 PM, Michael Buesch wrote:
> This rewrites the error handling policies in the TX status handler.
> It tries to be error-tolerant as in "try hard to not crash the machine".
> It won't recover from errors (that are bugs in the firmware or driver),
> because that's impossible. However, it will return a more or less useful
> error message and bail out. It also tries hard to use rate-limited messages
> to not flood the syslog in case of a failure.
>
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
>
> ---
Tested and ACKed by Larry Finger. Not only does this improve the error handling
for b43, but it also appears to fix the skb == NULL error that I experienced
with the open-source firmware.
John - please push this into wireless-testing. It should also go to 2.6.32, but
it is likely too large for the current stage. At least Cc it to stable.
Larry
next prev parent reply other threads:[~2009-11-23 1:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-19 21:24 [PATCH] b43: Rewrite DMA Tx status handling sanity checks Michael Buesch
2009-11-22 17:52 ` Michael Buesch
2009-11-22 18:11 ` Larry Finger
2009-11-22 18:19 ` Michael Buesch
2009-11-23 1:34 ` Larry Finger [this message]
2009-11-23 10:30 ` Michael Buesch
2009-11-23 4:45 ` Larry Finger
2009-11-23 10:49 ` Michael Buesch
2009-11-23 11:00 ` Francesco Gringoli
2009-11-23 11:05 ` Michael Buesch
2009-11-23 15:41 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B09E691.8020205@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.