From: Arnd Bergmann <arnd@arndb.de>
To: Patrick Mullaney <pmullaney@novell.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
linux-kernel@vger.kernel.org,
alacrityvm-devel@lists.sourceforge.net
Subject: Re: [Bridge] [PATCH 3/3] macvlan: allow in-kernel modules to create and manage macvlan devices
Date: Fri, 27 Nov 2009 23:14:42 +0100 [thread overview]
Message-ID: <200911272314.42641.arnd@arndb.de> (raw)
In-Reply-To: <20091113195529.11184.19011.stgit@mimic.site>
On Friday 13 November 2009, Patrick Mullaney wrote:
>
> The macvlan driver didn't allow for creation/deletion of devices
> by other in-kernel modules. This patch provides common routines
> for both in-kernel and netlink based management. This patch
> also enables macvlan device support for gro for lower level
> devices that support gro.
I wonder if doing this way round is a good idea, why don't
you just use netlink to set up the endpoint device like
the current macvlan and macvtap do? I think doing it consistently
for all backends would be a significant advantage.
Arnd <><
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Patrick Mullaney <pmullaney@novell.com>
Cc: kaber@trash.net, netdev@vger.kernel.org,
alacrityvm-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [PATCH 3/3] macvlan: allow in-kernel modules to create and manage macvlan devices
Date: Fri, 27 Nov 2009 23:14:42 +0100 [thread overview]
Message-ID: <200911272314.42641.arnd@arndb.de> (raw)
In-Reply-To: <20091113195529.11184.19011.stgit@mimic.site>
On Friday 13 November 2009, Patrick Mullaney wrote:
>
> The macvlan driver didn't allow for creation/deletion of devices
> by other in-kernel modules. This patch provides common routines
> for both in-kernel and netlink based management. This patch
> also enables macvlan device support for gro for lower level
> devices that support gro.
I wonder if doing this way round is a good idea, why don't
you just use netlink to set up the endpoint device like
the current macvlan and macvtap do? I think doing it consistently
for all backends would be a significant advantage.
Arnd <><
next prev parent reply other threads:[~2009-11-27 22:14 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 22:27 [Bridge] [PATCH 0/4] vbus: venet macvlan support Patrick Mullaney
2009-11-10 22:27 ` Patrick Mullaney
2009-11-10 22:27 ` [Bridge] [PATCH 1/4] macvlan: derived from Arnd Bergmann's patch for macvtap Patrick Mullaney
2009-11-10 22:27 ` Patrick Mullaney
2009-11-10 22:27 ` [Bridge] [PATCH 2/4] macvlan: allow in-kernel modules to create and manage macvlan devices Patrick Mullaney
2009-11-10 22:27 ` Patrick Mullaney
2009-11-11 15:29 ` [Bridge] " Patrick McHardy
2009-11-11 15:29 ` Patrick McHardy
2009-11-12 18:05 ` [PATCH] netdevice: provide common routine for macvlan and vlan operstate management Patrick Mullaney
2009-11-12 18:21 ` Patrick McHardy
2009-11-13 19:55 ` [Bridge] [PATCH 0/3] macvlan: support for guest vm direct rx/tx Patrick Mullaney
2009-11-13 19:55 ` Patrick Mullaney
2009-11-13 19:55 ` [Bridge] [PATCH 1/3] netdevice: provide common routine for macvlan and vlan operstate management Patrick Mullaney
2009-11-13 19:55 ` Patrick Mullaney
2009-11-27 13:09 ` [Bridge] " Arnd Bergmann
2009-11-27 13:09 ` Arnd Bergmann
2009-11-13 19:55 ` [Bridge] [PATCH 2/3] macvlan: derived from Arnd Bergmann's patch for macvtap Patrick Mullaney
2009-11-13 19:55 ` Patrick Mullaney
2009-11-13 19:55 ` [Bridge] [PATCH 3/3] macvlan: allow in-kernel modules to create and manage macvlan devices Patrick Mullaney
2009-11-13 19:55 ` Patrick Mullaney
2009-11-27 22:14 ` Arnd Bergmann [this message]
2009-11-27 22:14 ` Arnd Bergmann
2009-11-27 22:19 ` [Bridge] " Arnd Bergmann
2009-11-27 22:19 ` Arnd Bergmann
2009-11-13 21:27 ` [Bridge] [PATCH 0/3] macvlan: support for guest vm direct rx/tx Stephen Hemminger
2009-11-13 21:27 ` Stephen Hemminger
2009-11-27 23:43 ` [Bridge] " Arnd Bergmann
2009-11-27 23:43 ` Arnd Bergmann
2009-11-28 0:19 ` [Bridge] " David Miller
2009-11-28 0:19 ` David Miller
2009-11-28 5:38 ` [Bridge] " Stephen Hemminger
2009-11-28 5:38 ` Stephen Hemminger
2009-11-28 6:58 ` [Bridge] " David Miller
2009-11-28 6:58 ` David Miller
2009-11-10 22:28 ` [Bridge] [PATCH 3/4] venetdev: support common venet netdev routines Patrick Mullaney
2009-11-10 22:28 ` Patrick Mullaney
2009-11-10 22:28 ` [Bridge] [PATCH 4/4] venet-macvlan: add new driver to connect a venet to a macvlan netdevice Patrick Mullaney
2009-11-10 22:28 ` Patrick Mullaney
2009-11-11 15:36 ` [Bridge] " Patrick McHardy
2009-11-11 15:36 ` Patrick McHardy
2009-11-12 15:44 ` [Bridge] [PATCH 0/4] vbus: venet macvlan support Gregory Haskins
2009-11-12 15:44 ` Gregory Haskins
2009-11-12 15:53 ` [Bridge] " Patrick McHardy
2009-11-12 15:53 ` Patrick McHardy
2009-11-12 15:54 ` [Bridge] " Gregory Haskins
2009-11-12 15:54 ` Gregory Haskins
2009-11-12 15:59 ` [Bridge] " Patrick McHardy
2009-11-12 15:59 ` Patrick McHardy
-- strict thread matches above, loose matches on Subject: below --
2009-12-03 20:40 [Bridge] [PATCH 3/3] macvlan: allow in-kernel modules to create and manage macvlan devices Patrick Mullaney
2009-12-03 20:45 Patrick Mullaney
2009-12-03 21:28 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911272314.42641.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=alacrityvm-devel@lists.sourceforge.net \
--cc=bridge@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pmullaney@novell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.