All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Patrick Mullaney <pmullaney@novell.com>
Cc: arnd@arndb.de, netdev@vger.kernel.org,
	bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	alacrityvm-devel@lists.sourceforge.net, evb@yahoogroups.com
Subject: Re: [Bridge] [PATCH 4/4] venet-macvlan: add new driver to connect a venet to a	macvlan netdevice
Date: Wed, 11 Nov 2009 16:36:06 +0100	[thread overview]
Message-ID: <4AFAD9E6.2020109@trash.net> (raw)
In-Reply-To: <20091110222812.24100.42756.stgit@mimic.site>

Patrick Mullaney wrote:
> This driver implements a macvlan device as a venet device that can
> be connected to vbus. Since it is a macvlan device, it provides
> a more direct path to the underlying adapter by avoiding the
> bridge.

> --- /dev/null
> +++ b/kernel/vbus/devices/venet/macvlan.c
> ...
> +struct venetmacv {
> +	struct macvlan_dev mdev;
> +	unsigned char ll_ifname[IFNAMSIZ];
> +	struct venetdev dev;
> +	const struct net_device_ops *macvlan_netdev_ops;
> +};

macvlan might destroy the device below you when the underlying
device is unregistered. You need to handle this by releasing
the venetmacv device. Check out the NETDEV_UNREGISTER case in
macvlan_device_event().

WARNING: multiple messages have this Message-ID (diff)
From: Patrick McHardy <kaber@trash.net>
To: Patrick Mullaney <pmullaney@novell.com>
Cc: alacrityvm-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, arnd@arndb.de,
	bridge@lists.linux-foundation.org, evb@yahoogroups.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH 4/4] venet-macvlan: add new driver to connect a venet to a	macvlan netdevice
Date: Wed, 11 Nov 2009 16:36:06 +0100	[thread overview]
Message-ID: <4AFAD9E6.2020109@trash.net> (raw)
In-Reply-To: <20091110222812.24100.42756.stgit@mimic.site>

Patrick Mullaney wrote:
> This driver implements a macvlan device as a venet device that can
> be connected to vbus. Since it is a macvlan device, it provides
> a more direct path to the underlying adapter by avoiding the
> bridge.

> --- /dev/null
> +++ b/kernel/vbus/devices/venet/macvlan.c
> ...
> +struct venetmacv {
> +	struct macvlan_dev mdev;
> +	unsigned char ll_ifname[IFNAMSIZ];
> +	struct venetdev dev;
> +	const struct net_device_ops *macvlan_netdev_ops;
> +};

macvlan might destroy the device below you when the underlying
device is unregistered. You need to handle this by releasing
the venetmacv device. Check out the NETDEV_UNREGISTER case in
macvlan_device_event().

  reply	other threads:[~2009-11-11 15:36 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-10 22:27 [Bridge] [PATCH 0/4] vbus: venet macvlan support Patrick Mullaney
2009-11-10 22:27 ` Patrick Mullaney
2009-11-10 22:27 ` [Bridge] [PATCH 1/4] macvlan: derived from Arnd Bergmann's patch for macvtap Patrick Mullaney
2009-11-10 22:27   ` Patrick Mullaney
2009-11-10 22:27 ` [Bridge] [PATCH 2/4] macvlan: allow in-kernel modules to create and manage macvlan devices Patrick Mullaney
2009-11-10 22:27   ` Patrick Mullaney
2009-11-11 15:29   ` [Bridge] " Patrick McHardy
2009-11-11 15:29     ` Patrick McHardy
2009-11-12 18:05     ` [PATCH] netdevice: provide common routine for macvlan and vlan operstate management Patrick Mullaney
2009-11-12 18:21       ` Patrick McHardy
2009-11-13 19:55     ` [Bridge] [PATCH 0/3] macvlan: support for guest vm direct rx/tx Patrick Mullaney
2009-11-13 19:55       ` Patrick Mullaney
2009-11-13 19:55       ` [Bridge] [PATCH 1/3] netdevice: provide common routine for macvlan and vlan operstate management Patrick Mullaney
2009-11-13 19:55         ` Patrick Mullaney
2009-11-27 13:09         ` [Bridge] " Arnd Bergmann
2009-11-27 13:09           ` Arnd Bergmann
2009-11-13 19:55       ` [Bridge] [PATCH 2/3] macvlan: derived from Arnd Bergmann's patch for macvtap Patrick Mullaney
2009-11-13 19:55         ` Patrick Mullaney
2009-11-13 19:55       ` [Bridge] [PATCH 3/3] macvlan: allow in-kernel modules to create and manage macvlan devices Patrick Mullaney
2009-11-13 19:55         ` Patrick Mullaney
2009-11-27 22:14         ` [Bridge] " Arnd Bergmann
2009-11-27 22:14           ` Arnd Bergmann
2009-11-27 22:19         ` [Bridge] " Arnd Bergmann
2009-11-27 22:19           ` Arnd Bergmann
2009-11-13 21:27       ` [Bridge] [PATCH 0/3] macvlan: support for guest vm direct rx/tx Stephen Hemminger
2009-11-13 21:27         ` Stephen Hemminger
2009-11-27 23:43         ` [Bridge] " Arnd Bergmann
2009-11-27 23:43           ` Arnd Bergmann
2009-11-28  0:19           ` [Bridge] " David Miller
2009-11-28  0:19             ` David Miller
2009-11-28  5:38             ` [Bridge] " Stephen Hemminger
2009-11-28  5:38               ` Stephen Hemminger
2009-11-28  6:58               ` [Bridge] " David Miller
2009-11-28  6:58                 ` David Miller
2009-11-10 22:28 ` [Bridge] [PATCH 3/4] venetdev: support common venet netdev routines Patrick Mullaney
2009-11-10 22:28   ` Patrick Mullaney
2009-11-10 22:28 ` [Bridge] [PATCH 4/4] venet-macvlan: add new driver to connect a venet to a macvlan netdevice Patrick Mullaney
2009-11-10 22:28   ` Patrick Mullaney
2009-11-11 15:36   ` Patrick McHardy [this message]
2009-11-11 15:36     ` Patrick McHardy
2009-11-12 15:44 ` [Bridge] [PATCH 0/4] vbus: venet macvlan support Gregory Haskins
2009-11-12 15:44   ` Gregory Haskins
2009-11-12 15:53   ` [Bridge] " Patrick McHardy
2009-11-12 15:53     ` Patrick McHardy
2009-11-12 15:54     ` [Bridge] " Gregory Haskins
2009-11-12 15:54       ` Gregory Haskins
2009-11-12 15:59       ` [Bridge] " Patrick McHardy
2009-11-12 15:59         ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AFAD9E6.2020109@trash.net \
    --to=kaber@trash.net \
    --cc=alacrityvm-devel@lists.sourceforge.net \
    --cc=arnd@arndb.de \
    --cc=bridge@lists.linux-foundation.org \
    --cc=evb@yahoogroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pmullaney@novell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.