Re: [PATCH] ALSA: ASoc: Add regulator support to CS4270 codec driver

[Daniel Mack <daniel@caiaq.de>]

On Sat, Nov 28, 2009 at 04:18:05PM -0600, Timur Tabi wrote:
> Mark Brown wrote:
> >The regulator header file handles that -it provides stub versions of the
> >core consumer API calls to save all the drivers having to have
> >conditional code in them.
> 
> Ok, that works for me.
> 
> However, when I tried to apply the patch to the for-2.6.33 branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git,
> it fails:
> 
> $ patch -p 1 <
> "/home/b04825/.mozilla/seamonkey/fl00b35q.default/Mail/Local
> Folders/patches"
> patching file sound/soc/codecs/cs4270.c
> Hunk #5 FAILED at 651.
> Hunk #6 succeeded at 673 (offset -7 lines).
> Hunk #8 succeeded at 779 (offset -7 lines).
> Hunk #9 succeeded at 895 (offset -16 lines).
> 1 out of 9 hunks FAILED -- saving rejects to file sound/soc/codecs/cs4270.c.rej
> 
> I'm on vacation until the end of the year, so I can't test this
> driver thoroughly, but I'd like to make sure it at least compiles
> and boots before I ack it.

It does compile and does boot, we're testing this already on mayn
devices and it works fine. However, there have been updates to that
driver due to changes in the suspend/resume paths.

Mark, can you resolve those conflicts easily or do you want me to do it?

Thanks,
Daniel