From: Simon Horman <horms@verge.net.au>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: netdev@vger.kernel.org, gospo@redhat.com,
Greg Rose <gregory.v.rose@intel.com>,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Subject: Re: [RFC PATCH 06/12] ixgbe: Add SR-IOV specific modules to driver Makefile
Date: Thu, 10 Dec 2009 11:17:39 +1100 [thread overview]
Message-ID: <20091210001739.GF4163@verge.net.au> (raw)
In-Reply-To: <20091208221454.28373.78622.stgit@localhost.localdomain>
On Tue, Dec 08, 2009 at 02:14:55PM -0800, Jeff Kirsher wrote:
> From: Greg Rose <gregory.v.rose@intel.com>
>
> Add the mailbox and SR-IOV feature modules to the ixgbe driver Makefile.
>
> Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> ---
>
> drivers/net/ixgbe/Makefile | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile
> index 21b41f4..1dd867d 100644
> --- a/drivers/net/ixgbe/Makefile
> +++ b/drivers/net/ixgbe/Makefile
> @@ -33,7 +33,8 @@
> obj-$(CONFIG_IXGBE) += ixgbe.o
>
> ixgbe-objs := ixgbe_main.o ixgbe_common.o ixgbe_ethtool.o \
> - ixgbe_82599.o ixgbe_82598.o ixgbe_phy.o
> + ixgbe_82599.o ixgbe_82598.o ixgbe_phy.o ixgbe_sriov.o \
> + ixgbe_mbx.o
>
> ixgbe-$(CONFIG_IXGBE_DCB) += ixgbe_dcb.o ixgbe_dcb_82598.o \
> ixgbe_dcb_82599.o ixgbe_dcb_nl.o
This change needs to be moved to before
"[RFC PATCH 04/12] ixgbe: Add SR-IOV feature enablement code"
to avoid missing symbols in the driver. But perhaps it would be easier to
just incorporate it into the patch that introduces the new
source files?
$ make
...
WARNING: "mbx_ops_82599" [drivers/net/ixgbe/ixgbe.ko] undefined!
There are more warnings after applying
"[RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module"
$ make
...
WARNING: "mbx_ops_82599" [drivers/net/ixgbe/ixgbe.ko] undefined!
WARNING: "ixgbe_init_mbx_params_pf" [drivers/net/ixgbe/ixgbe.ko] undefined!
WARNING: "ixgbe_vf_configuration" [drivers/net/ixgbe/ixgbe.ko] undefined!
WARNING: "ixgbe_restore_vf_multicasts" [drivers/net/ixgbe/ixgbe.ko] undefined!
WARNING: "ixgbe_msg_task" [drivers/net/ixgbe/ixgbe.ko] undefined!
WARNING: "ixgbe_set_vmolr" [drivers/net/ixgbe/ixgbe.ko] undefined!
next prev parent reply other threads:[~2009-12-10 0:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-08 22:13 [RFC PATCH 01/12] ixgbe: Mailbox header and code module Jeff Kirsher
2009-12-08 22:13 ` [RFC PATCH 02/12] ixgbe: Add SR-IOV specific features Jeff Kirsher
2009-12-08 22:13 ` [RFC PATCH 03/12] ixgbe: Add SR-IOV register, structure and bit defines Jeff Kirsher
2009-12-10 0:06 ` Simon Horman
2009-12-08 22:14 ` [RFC PATCH 04/12] ixgbe: Add SR-IOV feature enablement code Jeff Kirsher
2009-12-08 22:14 ` [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module Jeff Kirsher
2009-12-10 0:45 ` Simon Horman
2009-12-10 0:49 ` Rose, Gregory V
2009-12-10 1:04 ` Simon Horman
2009-12-08 22:14 ` [RFC PATCH 06/12] ixgbe: Add SR-IOV specific modules to driver Makefile Jeff Kirsher
2009-12-10 0:17 ` Simon Horman [this message]
2009-12-08 22:15 ` [RFC PATCH 07/12] ixgbevf: Macros, data structures, useful defines and registers Jeff Kirsher
2009-12-08 22:15 ` [RFC PATCH 08/12] ixgbevf: 82599 Virtual Function core functions and header Jeff Kirsher
2009-12-08 22:15 ` [RFC PATCH 09/12] ixgbevf: Mailbox communication Jeff Kirsher
2009-12-08 22:16 ` [RFC PATCH 10/12] ixgbevf: Driver main and ethool interface module and main header Jeff Kirsher
2009-12-09 17:57 ` Ben Hutchings
2009-12-09 18:02 ` Rose, Gregory V
2009-12-08 22:16 ` [RFC PATCH 11/12] ixgbevf: Driver Makefile Jeff Kirsher
2009-12-08 22:16 ` [RFC PATCH 12/12] ixgbevf: Kconfig, Makefile and Documentation Jeff Kirsher
2009-12-08 22:41 ` Randy Dunlap
2009-12-08 22:49 ` Rose, Gregory V
2009-12-10 0:59 ` Simon Horman
2009-12-10 1:04 ` Rose, Gregory V
2009-12-10 0:50 ` [RFC PATCH 01/12] ixgbe: Mailbox header and code module Simon Horman
2009-12-10 0:53 ` Rose, Gregory V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091210001739.GF4163@verge.net.au \
--to=horms@verge.net.au \
--cc=gospo@redhat.com \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.