All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: "Rose, Gregory V" <gregory.v.rose@intel.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"gospo@redhat.com" <gospo@redhat.com>
Subject: Re: [RFC PATCH 12/12] ixgbevf: Kconfig, Makefile and Documentation
Date: Thu, 10 Dec 2009 11:59:49 +1100	[thread overview]
Message-ID: <20091210005949.GI4163@verge.net.au> (raw)
In-Reply-To: <43F901BD926A4E43B106BF17856F07558C0F4B7F@orsmsx508.amr.corp.intel.com>

On Tue, Dec 08, 2009 at 02:49:21PM -0800, Rose, Gregory V wrote:
> >-----Original Message-----
> >From: Randy Dunlap [mailto:randy.dunlap@oracle.com]
> >Sent: Tuesday, December 08, 2009 2:42 PM
> >To: Kirsher, Jeffrey T
> >Cc: netdev@vger.kernel.org; gospo@redhat.com; Rose, Gregory V
> >Subject: Re: [RFC PATCH 12/12] ixgbevf: Kconfig, Makefile and
> >Documentation
> >
> >> +The ixgbevf driver supports 82599-based virtual function devices that
> >can only
> >> +be activated on kernels with CONFIG_PCI_IOV enabled.
> >> +
> >> +The guest OS loading the ixgbevf driver must support MSI-X
> >interrupts.
> >
> >Hi,
> >
> >Could the Kconfig language express some of these requirements, or
> >am I confused between the host and the guest OS?
> [Rose, Gregory V] 
> 
> The guest OS must also support MSI-X interrupts.  It is a requirement of our VF device to use MSI-X.
> 
> >
> >
> >> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> >> index 0bbd5ae..a484415 100644
> >> --- a/drivers/net/Kconfig
> >> +++ b/drivers/net/Kconfig
> >> @@ -2614,6 +2614,27 @@ config IXGBE_DCB
> >>
> >>  	  If unsure, say N.
> >>
> >> +config IXGBEVF
> >> +       tristate "Intel(R) 82599 Virtual Function Ethernet support"
> >> +       depends on PCI
> >
> >	depends on PCI_IOV && PCI_MSI
> >??
> >
> [Rose, Gregory V] 
> 
> The guest does not need to have IOV support configured to use the VF device but it does need MSI-X.  We'll incorporate this suggested change.
> 
> Thanks for your comments.

The igbvf driver can also run on the host or indeed on a system
without virtualisation. Is the same true of the ixgbevf driver?


  reply	other threads:[~2009-12-10  0:59 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-08 22:13 [RFC PATCH 01/12] ixgbe: Mailbox header and code module Jeff Kirsher
2009-12-08 22:13 ` [RFC PATCH 02/12] ixgbe: Add SR-IOV specific features Jeff Kirsher
2009-12-08 22:13 ` [RFC PATCH 03/12] ixgbe: Add SR-IOV register, structure and bit defines Jeff Kirsher
2009-12-10  0:06   ` Simon Horman
2009-12-08 22:14 ` [RFC PATCH 04/12] ixgbe: Add SR-IOV feature enablement code Jeff Kirsher
2009-12-08 22:14 ` [RFC PATCH 05/12] ixgbe: Add SR-IOV features to main module Jeff Kirsher
2009-12-10  0:45   ` Simon Horman
2009-12-10  0:49     ` Rose, Gregory V
2009-12-10  1:04       ` Simon Horman
2009-12-08 22:14 ` [RFC PATCH 06/12] ixgbe: Add SR-IOV specific modules to driver Makefile Jeff Kirsher
2009-12-10  0:17   ` Simon Horman
2009-12-08 22:15 ` [RFC PATCH 07/12] ixgbevf: Macros, data structures, useful defines and registers Jeff Kirsher
2009-12-08 22:15 ` [RFC PATCH 08/12] ixgbevf: 82599 Virtual Function core functions and header Jeff Kirsher
2009-12-08 22:15 ` [RFC PATCH 09/12] ixgbevf: Mailbox communication Jeff Kirsher
2009-12-08 22:16 ` [RFC PATCH 10/12] ixgbevf: Driver main and ethool interface module and main header Jeff Kirsher
2009-12-09 17:57   ` Ben Hutchings
2009-12-09 18:02     ` Rose, Gregory V
2009-12-08 22:16 ` [RFC PATCH 11/12] ixgbevf: Driver Makefile Jeff Kirsher
2009-12-08 22:16 ` [RFC PATCH 12/12] ixgbevf: Kconfig, Makefile and Documentation Jeff Kirsher
2009-12-08 22:41   ` Randy Dunlap
2009-12-08 22:49     ` Rose, Gregory V
2009-12-10  0:59       ` Simon Horman [this message]
2009-12-10  1:04         ` Rose, Gregory V
2009-12-10  0:50 ` [RFC PATCH 01/12] ixgbe: Mailbox header and code module Simon Horman
2009-12-10  0:53   ` Rose, Gregory V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091210005949.GI4163@verge.net.au \
    --to=horms@verge.net.au \
    --cc=gospo@redhat.com \
    --cc=gregory.v.rose@intel.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.