From: Marcelo Tosatti <mtosatti@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: Fix possible circular locking in kvm_vm_ioctl_assign_device()
Date: Mon, 14 Dec 2009 17:12:33 -0200 [thread overview]
Message-ID: <20091214191233.GA6065@amt.cnet> (raw)
In-Reply-To: <1260176284-4858-1-git-send-email-sheng@linux.intel.com>
On Mon, Dec 07, 2009 at 04:58:04PM +0800, Sheng Yang wrote:
> One possible order is:
>
> KVM_CREATE_IRQCHIP ioctl(took kvm->lock) -> kvm_iobus_register_dev() ->
> down_write(kvm->slots_lock).
>
> The other one is in kvm_vm_ioctl_assign_device(), which take kvm->slots_lock
> first, then kvm->lock.
>
> Observe it due to kernel locking debug warnings.
Sheng,
Looks good.
Can you also update the comment on top of kvm_main.c?
next prev parent reply other threads:[~2009-12-14 19:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-07 8:58 [PATCH] KVM: Fix possible circular locking in kvm_vm_ioctl_assign_device() Sheng Yang
2009-12-14 7:14 ` Sheng Yang
2009-12-14 9:36 ` Avi Kivity
2009-12-14 19:12 ` Marcelo Tosatti [this message]
2009-12-15 2:28 ` Sheng Yang
2009-12-15 9:35 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091214191233.GA6065@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.