From: Avi Kivity <avi@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: Fix possible circular locking in kvm_vm_ioctl_assign_device()
Date: Tue, 15 Dec 2009 11:35:13 +0200 [thread overview]
Message-ID: <4B275851.8010904@redhat.com> (raw)
In-Reply-To: <1260844087-5485-1-git-send-email-sheng@linux.intel.com>
On 12/15/2009 04:28 AM, Sheng Yang wrote:
> One possible order is:
>
> KVM_CREATE_IRQCHIP ioctl(took kvm->lock) -> kvm_iobus_register_dev() ->
> down_write(kvm->slots_lock).
>
> The other one is in kvm_vm_ioctl_assign_device(), which take kvm->slots_lock
> first, then kvm->lock.
>
> Update the comment of lock order as well.
>
> Observe it due to kernel locking debug warnings.
>
Applied and queued for 2.6.33, thanks.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-12-15 9:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-07 8:58 [PATCH] KVM: Fix possible circular locking in kvm_vm_ioctl_assign_device() Sheng Yang
2009-12-14 7:14 ` Sheng Yang
2009-12-14 9:36 ` Avi Kivity
2009-12-14 19:12 ` Marcelo Tosatti
2009-12-15 2:28 ` Sheng Yang
2009-12-15 9:35 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B275851.8010904@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.