All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] KVM: Fix possible circular locking in kvm_vm_ioctl_assign_device()
Date: Mon, 14 Dec 2009 11:36:51 +0200	[thread overview]
Message-ID: <4B260733.6080203@redhat.com> (raw)
In-Reply-To: <200912141514.00291.sheng@linux.intel.com>

On 12/14/2009 09:14 AM, Sheng Yang wrote:
> On Monday 07 December 2009 16:58:04 Sheng Yang wrote:
>    
>> One possible order is:
>>
>> KVM_CREATE_IRQCHIP ioctl(took kvm->lock) ->  kvm_iobus_register_dev() ->
>> down_write(kvm->slots_lock).
>>
>> The other one is in kvm_vm_ioctl_assign_device(), which take
>>   kvm->slots_lock first, then kvm->lock.
>>
>> Observe it due to kernel locking debug warnings.
>>
>> Signed-off-by: Sheng Yang<sheng@linux.intel.com>
>>      
> Avi? Marcelo?
>
>    

Sorry, hunting a regression so the tree is frozen.  Will review soon.

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2009-12-14  9:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-07  8:58 [PATCH] KVM: Fix possible circular locking in kvm_vm_ioctl_assign_device() Sheng Yang
2009-12-14  7:14 ` Sheng Yang
2009-12-14  9:36   ` Avi Kivity [this message]
2009-12-14 19:12 ` Marcelo Tosatti
2009-12-15  2:28   ` Sheng Yang
2009-12-15  9:35     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B260733.6080203@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=sheng@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.