All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCHv2 00/12]posix_acl: Add the check items
Date: Mon, 21 Dec 2009 13:36:54 +0100	[thread overview]
Message-ID: <20091221123654.GA9201@lst.de> (raw)
In-Reply-To: <4B2F6153.8010609@gmail.com>

I like taking these checks into posix_acl_valid, but I think the patch
submission needs a bit more work.

All the patches are extremly whitespace mangled.  And I don't think
splitting them up makes a whole lot of sense, when we do API changes
like this we usually fix up all callers.  So please try to fix your
mailer, merged them all into one, and maybe also chose a more
descriptive subject line, e.g.

Subject: take checks for NULL and error pointers into posix_acl_valid()


And btw, at least the XFS change seems incorrect - previously we
returned NULL acl pointer and this patch changes it to -EINVAL.



WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Liuwenyi <qingshenlwy@gmail.com>
Cc: adilger@sun.com, jack@suse.cz, neilb@suse.de, jeffm@suse.com,
	joel.becker@oracle.com, bfields@fieldses.org,
	linux-mtd@lists.infradead.org, onlyflyer@gmail.com, hch@lst.de,
	tiger.yang@oracle.com, strongzgy@gmail.com, ffilzlnx@us.ibm.com,
	sandeen@sandeen.net, jmorris@namei.org, cluster-devel@redhat.com,
	aelder@sgi.com, cjb@laptop.org, mfasheh@suse.com,
	bharrosh@panasas.com, reiserfs-devel@vger.kernel.org,
	xfs@oss.sgi.com, xfs-masters@oss.sgi.com,
	viro@zeniv.linux.org.uk, swhiteho@redhat.com,
	chris.mason@oracle.com, linux-nfs@vger.kernel.org,
	linux-ext4@vger.kernel.org, tytso@mit.edu,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	serue@us.ibm.com, dwmw2@infradead.org,
	ocfs2-devel@oss.oracle.com
Subject: Re: [PATCHv2 00/12]posix_acl: Add the check items
Date: Mon, 21 Dec 2009 13:36:54 +0100	[thread overview]
Message-ID: <20091221123654.GA9201@lst.de> (raw)
In-Reply-To: <4B2F6153.8010609@gmail.com>

I like taking these checks into posix_acl_valid, but I think the patch
submission needs a bit more work.

All the patches are extremly whitespace mangled.  And I don't think
splitting them up makes a whole lot of sense, when we do API changes
like this we usually fix up all callers.  So please try to fix your
mailer, merged them all into one, and maybe also chose a more
descriptive subject line, e.g.

Subject: take checks for NULL and error pointers into posix_acl_valid()


And btw, at least the XFS change seems incorrect - previously we
returned NULL acl pointer and this patch changes it to -EINVAL.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Liuwenyi <qingshenlwy@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 00/12]posix_acl: Add the check items
Date: Mon, 21 Dec 2009 13:37:27 +0100	[thread overview]
Message-ID: <20091221123654.GA9201@lst.de> (raw)
In-Reply-To: <4B2F6153.8010609@gmail.com>

I like taking these checks into posix_acl_valid, but I think the patch
submission needs a bit more work.

All the patches are extremly whitespace mangled.  And I don't think
splitting them up makes a whole lot of sense, when we do API changes
like this we usually fix up all callers.  So please try to fix your
mailer, merged them all into one, and maybe also chose a more
descriptive subject line, e.g.

Subject: take checks for NULL and error pointers into posix_acl_valid()


And btw, at least the XFS change seems incorrect - previously we
returned NULL acl pointer and this patch changes it to -EINVAL.


  reply	other threads:[~2009-12-21 12:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-21 11:51 [PATCHv2 00/12]posix_acl: Add the check items Liuwenyi
2009-12-21 11:51 ` Liuwenyi
2009-12-21 12:36 ` Christoph Hellwig [this message]
2009-12-21 12:37   ` Christoph Hellwig
2009-12-21 12:36   ` Christoph Hellwig
2009-12-21 14:15   ` liu weni
2009-12-21 14:15     ` liu weni
2009-12-21 14:15     ` [Ocfs2-devel] " liu weni
2009-12-21 14:15     ` liu weni
2009-12-21 14:15     ` liu weni
2009-12-21 14:15     ` liu weni
2009-12-21 12:36 ` Christoph Hellwig
2009-12-21 12:36   ` Christoph Hellwig
2009-12-21 12:36 ` Christoph Hellwig
2009-12-21 12:36   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091221123654.GA9201@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.