From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] mx25: don't force input on FEC pins
Date: Tue, 22 Dec 2009 09:12:21 +0200 [thread overview]
Message-ID: <20091222071221.GA5286@jasper.tkos.co.il> (raw)
In-Reply-To: <20091221110409.GD15126@pengutronix.de>
Hi Sascha,
On Mon, Dec 21, 2009 at 12:04:09PM +0100, Sascha Hauer wrote:
> On Mon, Dec 14, 2009 at 12:19:40PM +0200, Baruch Siach wrote:
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> > arch/arm/plat-mxc/include/mach/iomux-mx25.h | 20 ++++++++++----------
> > 1 files changed, 10 insertions(+), 10 deletions(-)
>
> Can you explain why this is needed in the commit message please?
I tested FEC support without this patch and indeed this patch is not
necessary.
I just whether there is any benefit in setting the SION bit to a non default
mode.
Anyway, you can just discard this patch.
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
WARNING: multiple messages have this Message-ID (diff)
From: Baruch Siach <baruch@tkos.co.il>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Sascha Hauer <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/4] mx25: don't force input on FEC pins
Date: Tue, 22 Dec 2009 09:12:21 +0200 [thread overview]
Message-ID: <20091222071221.GA5286@jasper.tkos.co.il> (raw)
In-Reply-To: <20091221110409.GD15126@pengutronix.de>
Hi Sascha,
On Mon, Dec 21, 2009 at 12:04:09PM +0100, Sascha Hauer wrote:
> On Mon, Dec 14, 2009 at 12:19:40PM +0200, Baruch Siach wrote:
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> > arch/arm/plat-mxc/include/mach/iomux-mx25.h | 20 ++++++++++----------
> > 1 files changed, 10 insertions(+), 10 deletions(-)
>
> Can you explain why this is needed in the commit message please?
I tested FEC support without this patch and indeed this patch is not
necessary.
I just whether there is any benefit in setting the SION bit to a non default
mode.
Anyway, you can just discard this patch.
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2009-12-22 7:12 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-14 10:19 [PATCH 0/4] mx25: add support for FEC on i.MX25 PDK Baruch Siach
2009-12-14 10:19 ` Baruch Siach
2009-12-14 10:19 ` [PATCH 1/4] mx25: s/NO_PAD_CTL/NO_PAD_CTRL/ Baruch Siach
2009-12-14 10:19 ` Baruch Siach
2009-12-21 11:02 ` Sascha Hauer
2009-12-21 11:02 ` Sascha Hauer
2009-12-14 10:19 ` [PATCH 2/4] mx25: don't force input on FEC pins Baruch Siach
2009-12-14 10:19 ` Baruch Siach
2009-12-21 11:04 ` Sascha Hauer
2009-12-21 11:04 ` Sascha Hauer
2009-12-22 7:12 ` Baruch Siach [this message]
2009-12-22 7:12 ` Baruch Siach
2009-12-14 10:19 ` [PATCH 3/4] fec: add support for Freescale i.MX25 PDK (3DS) Baruch Siach
2009-12-14 10:19 ` Baruch Siach
2009-12-14 10:33 ` Sascha Hauer
2009-12-14 10:33 ` Sascha Hauer
2009-12-15 8:31 ` Baruch Siach
2009-12-15 8:31 ` Baruch Siach
2009-12-15 11:52 ` Greg Ungerer
2009-12-15 11:52 ` Greg Ungerer
2009-12-15 20:11 ` Baruch Siach
2009-12-15 20:11 ` Baruch Siach
2009-12-16 0:13 ` Greg Ungerer
2009-12-16 0:13 ` Greg Ungerer
2009-12-16 6:34 ` Baruch Siach
2009-12-16 6:34 ` Baruch Siach
2009-12-16 6:49 ` Greg Ungerer
2009-12-16 6:49 ` Greg Ungerer
2009-12-16 7:07 ` Baruch Siach
2009-12-16 7:07 ` Baruch Siach
2010-01-05 8:24 ` Baruch Siach
2010-01-05 8:24 ` Baruch Siach
2010-01-11 3:25 ` Greg Ungerer
2010-01-11 3:25 ` Greg Ungerer
2010-01-25 11:21 ` Baruch Siach
2010-01-25 11:21 ` Baruch Siach
2010-05-19 15:15 ` Jean-Christophe Dubois
2010-05-19 15:15 ` Jean-Christophe Dubois
2010-05-20 6:46 ` Sascha Hauer
2010-05-20 6:46 ` Sascha Hauer
2010-05-20 6:49 ` David Miller
2010-05-20 6:49 ` David Miller
2009-12-15 1:27 ` Greg Ungerer
2009-12-15 1:27 ` Greg Ungerer
2009-12-15 6:08 ` Baruch Siach
2009-12-15 6:08 ` Baruch Siach
2009-12-14 10:19 ` [PATCH 4/4] mx25: add support for FEC on i.MX25 PDK Baruch Siach
2009-12-14 10:19 ` Baruch Siach
2009-12-15 8:47 ` Baruch Siach
2009-12-15 8:47 ` Baruch Siach
2009-12-21 11:08 ` Sascha Hauer
2009-12-21 11:08 ` Sascha Hauer
2009-12-21 11:44 ` [PATCH 1/2] mx25: add support for FEC on i.MX25 Baruch Siach
2009-12-21 11:44 ` Baruch Siach
2009-12-21 11:44 ` [PATCH 2/2] mx25: pdk: add platform code for FEC support Baruch Siach
2009-12-21 11:44 ` Baruch Siach
2009-12-21 6:04 ` [PATCH 0/4] mx25: add support for FEC on i.MX25 PDK Baruch Siach
2009-12-21 6:04 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091222071221.GA5286@jasper.tkos.co.il \
--to=baruch@tkos.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.