All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthias Kaehlcke <matthias@kaehlcke.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] BUG_ON() uses macro unlikely(), which isn't defined
Date: Tue, 22 Dec 2009 17:28:26 +0100	[thread overview]
Message-ID: <20091222162826.GG32054@darwin> (raw)

include/common.h defines the BUG_ON macro:

#define BUG_ON(condition) do { if (unlikely((condition)!=0)) BUG(); }
while(0)

this macro isn't defined in common.h or its includes

i'd submit a patch to fix this, but i wonder what kind of fix is
preferred:

a) eliminate the use of 'unlikely' in BUG_ON
b) define likely() and unlikely() in common.h
c) define likely() and unlikely() elsewhere
d) ?

best regards

-- 
Matthias Kaehlcke
Embedded Linux Developer
Barcelona

    C treats you like a consenting adult. Pascal treats you like a
          naughty child. Ada treats you like a criminal
                      (Bruce Powel Douglass)
                                                                 .''`.
    using free software / Debian GNU/Linux | http://debian.org  : :'  :
                                                                `. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-

             reply	other threads:[~2009-12-22 16:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-22 16:28 Matthias Kaehlcke [this message]
2009-12-22 19:28 ` [U-Boot] BUG_ON() uses macro unlikely(), which isn't defined Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091222162826.GG32054@darwin \
    --to=matthias@kaehlcke.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.