[U-Boot] BUG_ON() uses macro unlikely(), which isn't defined

[U-Boot] BUG_ON() uses macro unlikely(), which isn't defined

[Matthias Kaehlcke]

include/common.h defines the BUG_ON macro:

#define BUG_ON(condition) do { if (unlikely((condition)!=0)) BUG(); }
while(0)

this macro isn't defined in common.h or its includes

i'd submit a patch to fix this, but i wonder what kind of fix is
preferred:

a) eliminate the use of 'unlikely' in BUG_ON
b) define likely() and unlikely() in common.h
c) define likely() and unlikely() elsewhere
d) ?

best regards

-- 
Matthias Kaehlcke
Embedded Linux Developer
Barcelona

    C treats you like a consenting adult. Pascal treats you like a
          naughty child. Ada treats you like a criminal
                      (Bruce Powel Douglass)
                                                                 .''`.
    using free software / Debian GNU/Linux | http://debian.org  : :'  :
                                                                `. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-

[U-Boot] BUG_ON() uses macro unlikely(), which isn't defined

[Mike Frysinger]

On Tuesday 22 December 2009 11:28:26 Matthias Kaehlcke wrote:
> b) define likely() and unlikely() in common.h
> c) define likely() and unlikely() elsewhere

one of these please, presumably however linux does it
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091222/64f88ac2/attachment.pgp