From: Jerome Glisse <glisse@freedesktop.org>
To: "Yuan, Shengquan" <shengquan.yuan@gmail.com>
Cc: dri-devel@lists.sf.net
Subject: Re: ttm_flag_masked in ttm_bo_util.c
Date: Mon, 11 Jan 2010 12:48:34 +0100 [thread overview]
Message-ID: <20100111114834.GA3499@localhost.localdomain> (raw)
In-Reply-To: <aa4d442e1001110020m6577fa21kbcde64c0c6509f4e@mail.gmail.com>
On Mon, Jan 11, 2010 at 04:20:00PM +0800, Yuan, Shengquan wrote:
> In function ttm_bo_move_ttm, ttm_bo_move_memcpy, and
> ttm_bo_move_accel_cleanup, just before function exits, there is:
> ttm_flag_masked(&save_flags, new_mem->placement,
> TTM_PL_MASK_MEMTYPE);
>
> Is it needed because save_flags is just a local variable?
>
> Thanks
> Austin
Looks like dead code, likely left over of some cut & paste :)
If Thomas confirms i think you can propose a patch to nuke those.
Cheers,
Jerome
------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
--
prev parent reply other threads:[~2010-01-11 11:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 8:20 ttm_flag_masked in ttm_bo_util.c Yuan, Shengquan
2010-01-11 11:48 ` Jerome Glisse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100111114834.GA3499@localhost.localdomain \
--to=glisse@freedesktop.org \
--cc=dri-devel@lists.sf.net \
--cc=shengquan.yuan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.