* ttm_flag_masked in ttm_bo_util.c
@ 2010-01-11 8:20 Yuan, Shengquan
2010-01-11 11:48 ` Jerome Glisse
0 siblings, 1 reply; 2+ messages in thread
From: Yuan, Shengquan @ 2010-01-11 8:20 UTC (permalink / raw)
To: dri-devel
In function ttm_bo_move_ttm, ttm_bo_move_memcpy, and
ttm_bo_move_accel_cleanup, just before function exits, there is:
ttm_flag_masked(&save_flags, new_mem->placement,
TTM_PL_MASK_MEMTYPE);
Is it needed because save_flags is just a local variable?
Thanks
Austin
------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
--
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: ttm_flag_masked in ttm_bo_util.c
2010-01-11 8:20 ttm_flag_masked in ttm_bo_util.c Yuan, Shengquan
@ 2010-01-11 11:48 ` Jerome Glisse
0 siblings, 0 replies; 2+ messages in thread
From: Jerome Glisse @ 2010-01-11 11:48 UTC (permalink / raw)
To: Yuan, Shengquan; +Cc: dri-devel
On Mon, Jan 11, 2010 at 04:20:00PM +0800, Yuan, Shengquan wrote:
> In function ttm_bo_move_ttm, ttm_bo_move_memcpy, and
> ttm_bo_move_accel_cleanup, just before function exits, there is:
> ttm_flag_masked(&save_flags, new_mem->placement,
> TTM_PL_MASK_MEMTYPE);
>
> Is it needed because save_flags is just a local variable?
>
> Thanks
> Austin
Looks like dead code, likely left over of some cut & paste :)
If Thomas confirms i think you can propose a patch to nuke those.
Cheers,
Jerome
------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
--
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-11 11:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-11 8:20 ttm_flag_masked in ttm_bo_util.c Yuan, Shengquan
2010-01-11 11:48 ` Jerome Glisse
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.