RFC: EDID and separate sync mode

RFC: EDID and separate sync mode

[Jerome Glisse]

X is just printing a warning for such mode, KMS is ignoring them.
It seems that such mode are still valid. I didn't found yet what
separate sync mode means, need to dig deeper in vesa specs. Is it
ok to do like X and just print a warning and add the mode ?

Cheers,
Jerome


------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
--

[PATCH] drm: EDID accept separate sync video mode

[Jerome Glisse]

X is accepting such video mode, do the same. Pointed out by Joshua Roys
on IRC. Fix https://bugzilla.redhat.com/show_bug.cgi?id=540024

Signed-off-by: Jerome Glisse <jglisse@redhat.com>
---
 drivers/gpu/drm/drm_edid.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 5c9f798..6d66383 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -634,7 +634,6 @@ static struct drm_display_mode *drm_mode_detailed(struct drm_device *dev,
 	}
 	if (!(pt->misc & DRM_EDID_PT_SEPARATE_SYNC)) {
 		printk(KERN_WARNING "integrated sync not supported\n");
-		return NULL;
 	}
 
 	/* it is incorrect if hsync/vsync width is zero */
-- 
1.6.5.2


------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
--

Re: [PATCH] drm: EDID accept separate sync video mode

[Ville Syrjälä]

On Thu, Jan 14, 2010 at 07:02:20PM +0100, Jerome Glisse wrote:
> X is accepting such video mode, do the same. Pointed out by Joshua Roys
> on IRC. Fix https://bugzilla.redhat.com/show_bug.cgi?id=540024
> 
> Signed-off-by: Jerome Glisse <jglisse@redhat.com>
> ---
>  drivers/gpu/drm/drm_edid.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 5c9f798..6d66383 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -634,7 +634,6 @@ static struct drm_display_mode *drm_mode_detailed(struct drm_device *dev,
>  	}
>  	if (!(pt->misc & DRM_EDID_PT_SEPARATE_SYNC)) {
>  		printk(KERN_WARNING "integrated sync not supported\n");
> -		return NULL;
>  	}

I suppose the patch title should be 'accept composite sync'. Perhaps the
error message could say composite sync too since then people would know
what it's trying to say. At least I've never heard the term integrated
sync before.

-- 
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/

------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
--