From: Gleb Natapov <gleb@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
Ryota Ozaki <ozaki.ryota@gmail.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH][STABLE-0.12] qemu-kvm: Disable cpu_set command to avoid segfault
Date: Mon, 18 Jan 2010 14:17:57 +0200 [thread overview]
Message-ID: <20100118121757.GE30698@redhat.com> (raw)
In-Reply-To: <4B544F48.2020706@redhat.com>
On Mon, Jan 18, 2010 at 02:08:40PM +0200, Avi Kivity wrote:
> On 01/18/2010 02:03 PM, Gleb Natapov wrote:
> >
> >>We should certainly fix it, but I doubt it's a good fit for the stable tree.
> >>
> >>Gleb, what would it take?
> >I have no idea about what causes segfault, so can't really tell how
> >invasive fix would be, but fixing segfault is not enough we will have to
> >backport BIOS code to seabios and IMO this code is too much for stable.
>
> I was asking about the BIOS code. Can you point me at it?
>
This is majority of AML part of it:
http://git.kernel.org/?p=virt/kvm/pcbios.git;a=blob;f=acpi-ssdt.dsl;h=d998867d70b6384c1f40356b9dd8a06b78b59022;hb=master
Seabios should be changed to allocate MADT table from memory that will
be marked as ACPI NVS in e820 and it should pass MADT table address into
AML code somehow (BOCH bios put it at address 0x0514 and AML read it
from there).
Note also that currently seabios created this SSDT dynamically and thus
can support any number of vcpus, by porting those changes we will limit
it to 15 vpus.
--
Gleb.
prev parent reply other threads:[~2010-01-18 12:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 17:27 [PATCH][STABLE-0.12] qemu-kvm: Disable cpu_set command to avoid segfault Ryota Ozaki
2010-01-18 11:34 ` Avi Kivity
2010-01-18 11:49 ` Daniel P. Berrange
2010-01-18 11:57 ` Avi Kivity
2010-01-18 12:03 ` Gleb Natapov
2010-01-18 12:08 ` Avi Kivity
2010-01-18 12:17 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100118121757.GE30698@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=berrange@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=ozaki.ryota@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.