From: Avi Kivity <avi@redhat.com>
To: Ryota Ozaki <ozaki.ryota@gmail.com>
Cc: kvm@vger.kernel.org, Gleb Natapov <gleb@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [PATCH][STABLE-0.12] qemu-kvm: Disable cpu_set command to avoid segfault
Date: Mon, 18 Jan 2010 13:34:21 +0200 [thread overview]
Message-ID: <4B54473D.4040700@redhat.com> (raw)
In-Reply-To: <1263230822-17703-1-git-send-email-ozaki.ryota@gmail.com>
On 01/11/2010 07:27 PM, Ryota Ozaki wrote:
> CPU hotplug feature is lost in this version. Even worse
> cpu_set qemu command may cause segfault.
>
> This patch fix the problem by just disabling it. It is
> enough for the stable branch.
>
> Signed-off-by: Ryota Ozaki<ozaki.ryota@gmail.com>
> Cc: Gleb Natapov<gleb@redhat.com>
> ---
> monitor.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index 6ff6e1f..4b566d2 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -829,7 +829,9 @@ static void do_cpu_set_nr(Monitor *mon, const QDict *qdict)
> return;
> }
> #if defined(TARGET_I386) || defined(TARGET_X86_64)
> - qemu_system_cpu_hot_add(value, state);
> + //qemu_system_cpu_hot_add(value, state);
> + monitor_printf(mon, "The feature is not avaiable in this version. "
> + "It will be back in a future version.\n");
> #endif
> }
>
Daniel, how is libvirt going to react to this?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-01-18 11:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 17:27 [PATCH][STABLE-0.12] qemu-kvm: Disable cpu_set command to avoid segfault Ryota Ozaki
2010-01-18 11:34 ` Avi Kivity [this message]
2010-01-18 11:49 ` Daniel P. Berrange
2010-01-18 11:57 ` Avi Kivity
2010-01-18 12:03 ` Gleb Natapov
2010-01-18 12:08 ` Avi Kivity
2010-01-18 12:17 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B54473D.4040700@redhat.com \
--to=avi@redhat.com \
--cc=berrange@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=ozaki.ryota@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.