All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-omap@vger.kernel.org, David Binderman <dcb314@hotmail.com>
Subject: [PATCH 7/9] omap: Fix arch/arm/mach-omap2/mux.c: Off by one error
Date: Tue, 02 Feb 2010 18:26:14 -0800	[thread overview]
Message-ID: <20100203022614.26347.38121.stgit@baageli.muru.com> (raw)
In-Reply-To: <20100203022318.26347.34734.stgit@baageli.muru.com>

David Binderman ran the sourceforge tool cppcheck over the source code of the
new Linux kernel 2.6.33-rc6:

[./arm/mach-omap2/mux.c:492]: (error) Buffer access out-of-bounds

13 characters + 1 digit + 1 zero byte is more than 14 characters.

Also add a comment on mode0 name length in case new omaps
start using longer names.

Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/mach-omap2/mux.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c
index 19001dd..5fedc50 100644
--- a/arch/arm/mach-omap2/mux.c
+++ b/arch/arm/mach-omap2/mux.c
@@ -486,7 +486,7 @@ int __init omap_mux_init_signal(char *muxname, int val)
 static inline void omap_mux_decode(struct seq_file *s, u16 val)
 {
 	char *flags[OMAP_MUX_MAX_NR_FLAGS];
-	char mode[14];
+	char mode[sizeof("OMAP_MUX_MODE") + 1];
 	int i = -1;
 
 	sprintf(mode, "OMAP_MUX_MODE%d", val & 0x7);
@@ -553,6 +553,7 @@ static int omap_mux_dbg_board_show(struct seq_file *s, void *unused)
 		if (!m0_name)
 			continue;
 
+		/* REVISIT: Needs to be updated if mode0 names get longer */
 		for (i = 0; i < OMAP_MUX_DEFNAME_LEN; i++) {
 			if (m0_name[i] == '\0') {
 				m0_def[i] = m0_name[i];


WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/9] omap: Fix arch/arm/mach-omap2/mux.c: Off by one error
Date: Tue, 02 Feb 2010 18:26:14 -0800	[thread overview]
Message-ID: <20100203022614.26347.38121.stgit@baageli.muru.com> (raw)
In-Reply-To: <20100203022318.26347.34734.stgit@baageli.muru.com>

David Binderman ran the sourceforge tool cppcheck over the source code of the
new Linux kernel 2.6.33-rc6:

[./arm/mach-omap2/mux.c:492]: (error) Buffer access out-of-bounds

13 characters + 1 digit + 1 zero byte is more than 14 characters.

Also add a comment on mode0 name length in case new omaps
start using longer names.

Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/mach-omap2/mux.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c
index 19001dd..5fedc50 100644
--- a/arch/arm/mach-omap2/mux.c
+++ b/arch/arm/mach-omap2/mux.c
@@ -486,7 +486,7 @@ int __init omap_mux_init_signal(char *muxname, int val)
 static inline void omap_mux_decode(struct seq_file *s, u16 val)
 {
 	char *flags[OMAP_MUX_MAX_NR_FLAGS];
-	char mode[14];
+	char mode[sizeof("OMAP_MUX_MODE") + 1];
 	int i = -1;
 
 	sprintf(mode, "OMAP_MUX_MODE%d", val & 0x7);
@@ -553,6 +553,7 @@ static int omap_mux_dbg_board_show(struct seq_file *s, void *unused)
 		if (!m0_name)
 			continue;
 
+		/* REVISIT: Needs to be updated if mode0 names get longer */
 		for (i = 0; i < OMAP_MUX_DEFNAME_LEN; i++) {
 			if (m0_name[i] == '\0') {
 				m0_def[i] = m0_name[i];

  parent reply	other threads:[~2010-02-03  2:25 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-03  2:25 [PATCH 0/9] omap fixes for 2.6.33-rc6 Tony Lindgren
2010-02-03  2:25 ` Tony Lindgren
2010-02-03  2:25 ` [PATCH 1/9] omap: define _toggle_gpio_edge_triggering only for OMAP1 Tony Lindgren
2010-02-03  2:25   ` Tony Lindgren
2010-02-03  8:13   ` Uwe Kleine-König
2010-02-03  8:13     ` Uwe Kleine-König
2010-02-03 16:57     ` Tony Lindgren
2010-02-03 16:57       ` Tony Lindgren
2010-02-03 17:10       ` Uwe Kleine-König
2010-02-03 17:10         ` Uwe Kleine-König
2010-02-03 17:25         ` Tony Lindgren
2010-02-03 17:25           ` Tony Lindgren
2010-02-03  2:25 ` [PATCH 2/9] omap: Remove old unused defines for OMAP_32KSYNCT_BASE Tony Lindgren
2010-02-03  2:25   ` Tony Lindgren
2010-02-03  2:26 ` [PATCH 3/9] ARCH OMAP : enable ARCH_HAS_HOLES_MEMORYMODEL for OMAP Tony Lindgren
2010-02-03  2:26   ` Tony Lindgren
2010-02-03  2:26 ` [PATCH 4/9] OMAP2/3: IRQ: ensure valid base address Tony Lindgren
2010-02-03  2:26   ` Tony Lindgren
2010-02-03  2:26 ` [PATCH 5/9] OMAP2/3: GPMC: ensure valid clock pointer Tony Lindgren
2010-02-03  2:26   ` Tony Lindgren
2010-02-03  2:26 ` [PATCH 6/9] omap: Fix 3630 mux errors Tony Lindgren
2010-02-03  2:26   ` Tony Lindgren
2010-02-03  2:26 ` Tony Lindgren [this message]
2010-02-03  2:26   ` [PATCH 7/9] omap: Fix arch/arm/mach-omap2/mux.c: Off by one error Tony Lindgren
2010-02-03  2:26 ` [PATCH 8/9] omap: Fix access to already released memory in clk_debugfs_register_one() Tony Lindgren
2010-02-03  2:26   ` Tony Lindgren
2010-02-03  2:26 ` [PATCH 9/9] omap: Disable serial port autoidle by default Tony Lindgren
2010-02-03  2:26   ` Tony Lindgren
2010-02-03  3:43   ` Tony Lindgren
2010-02-03  3:43     ` Tony Lindgren
2010-02-03 14:40     ` Kevin Hilman
2010-02-03 14:40       ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100203022614.26347.38121.stgit@baageli.muru.com \
    --to=tony@atomide.com \
    --cc=dcb314@hotmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.