Re: [PATCH 1/9] omap: define _toggle_gpio_edge_triggering only for OMAP1

[Tony Lindgren <tony@atomide.com>]

[-- Attachment #1: Type: text/plain, Size: 904 bytes --]

* Uwe Kleine-König <u.kleine-koenig@pengutronix.de> [100203 00:10]:
> Hi Tony,
> 
> On Tue, Feb 02, 2010 at 06:25:55PM -0800, Tony Lindgren wrote:
> > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > 
> > The only usage of _toggle_gpio_edge_triggering is in an
> > CONFIG_ARCH_OMAP1 is defined, too.
> This sentence is broken, isn't it?  I guess git commit played tricks on
> me here and removed a line, something like:
> 
> 	#ifdef CONFIG_ARCH_OMAP1 block, so only provide it if
> 
> Can you add it back?  I'd recommend doing the line break before the "an"
> in the first line instead of behind it.

Sure, updated patch below. The description makes more sense now :)

BTW, looks like with "git show --pretty=email" the From: field gets
messed up in the patch below. Author name shows OK in git though.

I wonder if that's a git bug for --pretty=email? Using version
1.6.6.1 it seems.

Tony

[-- Attachment #2: fix-gpio-warning-v2.patch --]
[-- Type: text/x-diff, Size: 1840 bytes --]

>From 9198bcd39f558dd56823f1c9983e2252fc99a501 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Date: Fri, 29 Jan 2010 14:20:05 -0800
Subject: [PATCH] omap: define _toggle_gpio_edge_triggering only for OMAP1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The only usage of _toggle_gpio_edge_triggering is in
an #ifdef CONFIG_ARCH_OMAP1 block, so only provide it if
CONFIG_ARCH_OMAP1 is defined, too.

This fixes a compiler warning:

	arch/arm/plat-omap/gpio.c:758: warning: '_toggle_gpio_edge_triggering' defined but not used

when compiling for ARCH_OMAP2, ARCH_OMAP3 or ARCH_OMAP4.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Kevin Hilman <khilman@deeprootsystems.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>

diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
index d17620c..d2422c7 100644
--- a/arch/arm/plat-omap/gpio.c
+++ b/arch/arm/plat-omap/gpio.c
@@ -750,6 +750,7 @@ static inline void set_24xx_gpio_triggering(struct gpio_bank *bank, int gpio,
 }
 #endif
 
+#ifdef CONFIG_ARCH_OMAP1
 /*
  * This only applies to chips that can't do both rising and falling edge
  * detection at once.  For all other chips, this function is a noop.
@@ -760,11 +761,9 @@ static void _toggle_gpio_edge_triggering(struct gpio_bank *bank, int gpio)
 	u32 l = 0;
 
 	switch (bank->method) {
-#ifdef CONFIG_ARCH_OMAP1
 	case METHOD_MPUIO:
 		reg += OMAP_MPUIO_GPIO_INT_EDGE;
 		break;
-#endif
 #ifdef CONFIG_ARCH_OMAP15XX
 	case METHOD_GPIO_1510:
 		reg += OMAP1510_GPIO_INT_CONTROL;
@@ -787,6 +786,7 @@ static void _toggle_gpio_edge_triggering(struct gpio_bank *bank, int gpio)
 
 	__raw_writel(l, reg);
 }
+#endif
 
 static int _set_gpio_triggering(struct gpio_bank *bank, int gpio, int trigger)
 {