From: Janne Grunau <j@jannau.net>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Julia Lawall <julia@diku.dk>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/8] drivers/media/video/hdpvr: introduce missing kfree
Date: Wed, 03 Feb 2010 14:12:10 +0000 [thread overview]
Message-ID: <20100203141210.GD7946@aniel.lan> (raw)
In-Reply-To: <4B684273.6040500@infradead.org>
Hej,
On Tue, Feb 02, 2010 at 01:19:15PM -0200, Mauro Carvalho Chehab wrote:
>
> Janne Grunau wrote:
> > On Fri, Sep 11, 2009 at 06:21:35PM +0200, Julia Lawall wrote:
> >> Error handling code following a kzalloc should free the allocated data.
> >
> > Thanks for the report. I'll commit a different patch which adds the buffer
> > to the buffer list as soon it is allocated. The hdpvr_free_buffers() in the
> > error handling code will clean it up then. See below:
>
> Any news about this subject? The current upstream code still misses the change bellow
it was fixed differently in cd0e280f
kind regards,
Janne
WARNING: multiple messages have this Message-ID (diff)
From: Janne Grunau <j@jannau.net>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Julia Lawall <julia@diku.dk>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/8] drivers/media/video/hdpvr: introduce missing kfree
Date: Wed, 3 Feb 2010 15:12:10 +0100 [thread overview]
Message-ID: <20100203141210.GD7946@aniel.lan> (raw)
In-Reply-To: <4B684273.6040500@infradead.org>
Hej,
On Tue, Feb 02, 2010 at 01:19:15PM -0200, Mauro Carvalho Chehab wrote:
>
> Janne Grunau wrote:
> > On Fri, Sep 11, 2009 at 06:21:35PM +0200, Julia Lawall wrote:
> >> Error handling code following a kzalloc should free the allocated data.
> >
> > Thanks for the report. I'll commit a different patch which adds the buffer
> > to the buffer list as soon it is allocated. The hdpvr_free_buffers() in the
> > error handling code will clean it up then. See below:
>
> Any news about this subject? The current upstream code still misses the change bellow
it was fixed differently in cd0e280f
kind regards,
Janne
next prev parent reply other threads:[~2010-02-03 14:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 16:21 [PATCH 3/8] drivers/media/video/hdpvr: introduce missing kfree Julia Lawall
2009-09-11 16:21 ` Julia Lawall
2009-09-16 11:13 ` Janne Grunau
2009-09-16 11:13 ` Janne Grunau
2010-02-02 15:19 ` Mauro Carvalho Chehab
2010-02-02 15:19 ` Mauro Carvalho Chehab
2010-02-03 14:12 ` Janne Grunau [this message]
2010-02-03 14:12 ` Janne Grunau
2010-02-03 14:28 ` Mauro Carvalho Chehab
2010-02-03 14:28 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100203141210.GD7946@aniel.lan \
--to=j@jannau.net \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.