All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Janne Grunau <j@jannau.net>
Cc: Julia Lawall <julia@diku.dk>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/8] drivers/media/video/hdpvr: introduce missing kfree
Date: Wed, 03 Feb 2010 14:28:19 +0000	[thread overview]
Message-ID: <4B698803.7010805@infradead.org> (raw)
In-Reply-To: <20100203141210.GD7946@aniel.lan>

Janne Grunau wrote:
> Hej, 
> 
> On Tue, Feb 02, 2010 at 01:19:15PM -0200, Mauro Carvalho Chehab wrote:
>> Janne Grunau wrote:
>>> On Fri, Sep 11, 2009 at 06:21:35PM +0200, Julia Lawall wrote:
>>>> Error handling code following a kzalloc should free the allocated data.
>>> Thanks for the report. I'll commit a different patch which adds the buffer
>>> to the buffer list as soon it is allocated. The hdpvr_free_buffers() in the
>>> error handling code will clean it up then. See below:
>> Any news about this subject? The current upstream code still misses the change bellow
> 
> it was fixed differently in cd0e280f

Thanks! I'm removing it from my queue :)

Now, the only hdpvr patch is this one:

hdpvr-video: cleanup signedness                                         http://patchwork.kernel.org/patch/74902


Cheers,
Mauro

WARNING: multiple messages have this Message-ID (diff)
From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Janne Grunau <j@jannau.net>
Cc: Julia Lawall <julia@diku.dk>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/8] drivers/media/video/hdpvr: introduce missing kfree
Date: Wed, 03 Feb 2010 12:28:19 -0200	[thread overview]
Message-ID: <4B698803.7010805@infradead.org> (raw)
In-Reply-To: <20100203141210.GD7946@aniel.lan>

Janne Grunau wrote:
> Hej, 
> 
> On Tue, Feb 02, 2010 at 01:19:15PM -0200, Mauro Carvalho Chehab wrote:
>> Janne Grunau wrote:
>>> On Fri, Sep 11, 2009 at 06:21:35PM +0200, Julia Lawall wrote:
>>>> Error handling code following a kzalloc should free the allocated data.
>>> Thanks for the report. I'll commit a different patch which adds the buffer
>>> to the buffer list as soon it is allocated. The hdpvr_free_buffers() in the
>>> error handling code will clean it up then. See below:
>> Any news about this subject? The current upstream code still misses the change bellow
> 
> it was fixed differently in cd0e280f

Thanks! I'm removing it from my queue :)

Now, the only hdpvr patch is this one:

hdpvr-video: cleanup signedness                                         http://patchwork.kernel.org/patch/74902


Cheers,
Mauro

  reply	other threads:[~2010-02-03 14:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-11 16:21 [PATCH 3/8] drivers/media/video/hdpvr: introduce missing kfree Julia Lawall
2009-09-11 16:21 ` Julia Lawall
2009-09-16 11:13 ` Janne Grunau
2009-09-16 11:13   ` Janne Grunau
2010-02-02 15:19   ` Mauro Carvalho Chehab
2010-02-02 15:19     ` Mauro Carvalho Chehab
2010-02-03 14:12     ` Janne Grunau
2010-02-03 14:12       ` Janne Grunau
2010-02-03 14:28       ` Mauro Carvalho Chehab [this message]
2010-02-03 14:28         ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B698803.7010805@infradead.org \
    --to=mchehab@infradead.org \
    --cc=j@jannau.net \
    --cc=julia@diku.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.