From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/2] Ocfs2: Move ocfs2 ioctl definitions from ocfs2_fs.h to new added ocfs2_ioctl.h.
Date: Fri, 5 Feb 2010 15:09:14 -0800 [thread overview]
Message-ID: <20100205230914.GC3416@mail.oracle.com> (raw)
In-Reply-To: <1262940717-16769-1-git-send-email-tristan.ye@oracle.com>
On Fri, Jan 08, 2010 at 04:51:56PM +0800, Tristan Ye wrote:
> Currently we were adding ioctl cmds/structures for ocfs2 into ocfs2_fs.h
> which was used for define ocfs2 on-disk layout. That sounds a little bit
> confusing, and it may be quickly polluted espcially when growing the
> ocfs2_info_request ioctls afterwards(it will grow i bet).
>
> As a result, such OCFS2 IOCs do need to be placed somewhere other than ocfs2_fs.h,
> a separated ocfs2_ioctl.h will be added to store such ioctl structures and definitions
> which could also be used from userspace to invoke the ioctls.
>
> What's more, the patch also introduces new structures and definitions for the new
> OCFS2_IOC_INFO.
Can I get a version of this patch that does not inlude
OCFS2_IOC_INFO? Separate out adding the INFO definitions. They can go
in the second patch, as they match the operations.
That way I can apply this patch even before INFO is ready.
Joel
--
"Always give your best, never get discouraged, never be petty; always
remember, others may hate you. Those who hate you don't win unless
you hate them. And then you destroy yourself."
- Richard M. Nixon
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2010-02-05 23:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-08 8:51 [Ocfs2-devel] [PATCH 1/2] Ocfs2: Move ocfs2 ioctl definitions from ocfs2_fs.h to new added ocfs2_ioctl.h Tristan Ye
2010-01-08 8:51 ` [Ocfs2-devel] [PATCH 2/2] Ocfs2: Add new OCFS2_IOC_INFO ioctl for ocfs2 v5 Tristan Ye
2010-02-05 23:09 ` Joel Becker [this message]
2010-02-08 2:24 ` [Ocfs2-devel] [PATCH 1/2] Ocfs2: Move ocfs2 ioctl definitions from ocfs2_fs.h to new added ocfs2_ioctl.h tristan
-- strict thread matches above, loose matches on Subject: below --
2010-02-05 9:59 Tristan Ye
2010-02-08 9:21 Tristan Ye
2010-02-17 6:10 ` Joel Becker
2010-02-24 7:51 Tiger Yang
2010-03-02 1:21 ` Joel Becker
2010-03-02 2:08 ` tristan
2010-03-02 2:32 ` Joel Becker
2010-03-02 3:13 ` tristan
2010-03-02 3:29 ` Joel Becker
2010-03-02 3:32 ` tristan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100205230914.GC3416@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.