From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/2] Ocfs2: Move ocfs2 ioctl definitions from ocfs2_fs.h to new added ocfs2_ioctl.h.
Date: Mon, 1 Mar 2010 18:32:17 -0800 [thread overview]
Message-ID: <20100302023217.GD447@mail.oracle.com> (raw)
In-Reply-To: <4B8C7304.8070108@oracle.com>
On Tue, Mar 02, 2010 at 10:08:04AM +0800, tristan wrote:
> Currently 'resize.h' and 'file.h' are using ioctl structures from
> 'ocfs2_ioctl.h', don't like 'resize.h', which only was included in
> 'resize.c', 'file.h' instead was referred everywhere:
>
> We therefore need to add 'ocfs2_ioctl.h' in many C sources to avoid
> compile warnings.
That's right, you put it in the C sources. This way we know
what includes each C file has, and only the C files needing the include
file actually include it.
Joel
--
"Every day I get up and look through the Forbes list of the richest
people in America. If I'm not there, I go to work."
- Robert Orben
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2010-03-02 2:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 7:51 [Ocfs2-devel] [PATCH 1/2] Ocfs2: Move ocfs2 ioctl definitions from ocfs2_fs.h to new added ocfs2_ioctl.h Tiger Yang
2010-02-24 7:51 ` [Ocfs2-devel] [PATCH 2/2] Ocfs2: Add new OCFS2_IOC_INFO ioctl for ocfs2 v6 Tiger Yang
2010-03-02 1:21 ` [Ocfs2-devel] [PATCH 1/2] Ocfs2: Move ocfs2 ioctl definitions from ocfs2_fs.h to new added ocfs2_ioctl.h Joel Becker
2010-03-02 2:08 ` tristan
2010-03-02 2:32 ` Joel Becker [this message]
2010-03-02 3:13 ` tristan
2010-03-02 3:29 ` Joel Becker
2010-03-02 3:32 ` tristan
-- strict thread matches above, loose matches on Subject: below --
2010-02-08 9:21 Tristan Ye
2010-02-17 6:10 ` Joel Becker
2010-02-05 9:59 Tristan Ye
2010-01-08 8:51 Tristan Ye
2010-02-05 23:09 ` Joel Becker
2010-02-08 2:24 ` tristan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100302023217.GD447@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.