From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/2] Ocfs2: Move ocfs2 ioctl definitions from ocfs2_fs.h to new added ocfs2_ioctl.h.
Date: Mon, 1 Mar 2010 17:21:21 -0800 [thread overview]
Message-ID: <20100302012121.GC447@mail.oracle.com> (raw)
In-Reply-To: <1266997872-17091-1-git-send-email-tiger.yang@oracle.com>
On Wed, Feb 24, 2010 at 03:51:11PM +0800, Tiger Yang wrote:
> diff --git a/fs/ocfs2/file.h b/fs/ocfs2/file.h
> index d66cf4f..eb891db 100644
> --- a/fs/ocfs2/file.h
> +++ b/fs/ocfs2/file.h
> @@ -26,6 +26,8 @@
> #ifndef OCFS2_FILE_H
> #define OCFS2_FILE_H
>
> +#include "ocfs2_ioctl.h"
I wanted to grab this for the merge window, but I see that
file.h is still including the new header. The header should be included
in the appropriate C file, not here. Please clean this up.
Joel
--
"It is not the function of our government to keep the citizen from
falling into error; it is the function of the citizen to keep the
government from falling into error."
- Robert H. Jackson
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2010-03-02 1:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 7:51 [Ocfs2-devel] [PATCH 1/2] Ocfs2: Move ocfs2 ioctl definitions from ocfs2_fs.h to new added ocfs2_ioctl.h Tiger Yang
2010-02-24 7:51 ` [Ocfs2-devel] [PATCH 2/2] Ocfs2: Add new OCFS2_IOC_INFO ioctl for ocfs2 v6 Tiger Yang
2010-03-02 1:21 ` Joel Becker [this message]
2010-03-02 2:08 ` [Ocfs2-devel] [PATCH 1/2] Ocfs2: Move ocfs2 ioctl definitions from ocfs2_fs.h to new added ocfs2_ioctl.h tristan
2010-03-02 2:32 ` Joel Becker
2010-03-02 3:13 ` tristan
2010-03-02 3:29 ` Joel Becker
2010-03-02 3:32 ` tristan
-- strict thread matches above, loose matches on Subject: below --
2010-02-08 9:21 Tristan Ye
2010-02-17 6:10 ` Joel Becker
2010-02-05 9:59 Tristan Ye
2010-01-08 8:51 Tristan Ye
2010-02-05 23:09 ` Joel Becker
2010-02-08 2:24 ` tristan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100302012121.GC447@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.