From: Rusty Russell <rusty@rustcorp.com.au>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtualization@lists.linux-foundation.org, markmc@redhat.com,
Anthony Liguori <anthony@codemonkey.ws>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [PATCH] virtio-spec: document MSI-X
Date: Fri, 12 Feb 2010 20:17:55 +1030 [thread overview]
Message-ID: <201002122017.55536.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20100211172236.GA20357@redhat.com>
On Fri, 12 Feb 2010 03:52:36 am Michael S. Tsirkin wrote:
> This documents MSI-X support in virtio.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Wow, great!
I reworked one paragraph for better grammar. Mainly adding "the":
(pseudo-patch):
Devices report such failures by returning +the+ NO_VECTOR value
when the relevant Vector field is read. After mapping an event to vector,
+the+ driver must verify success by reading the Vector field value: on
success, +the+ previously written value is returned-;-+, and+ on failure,
NO_VECTOR -value- is returned. If +a+ mapping failure is detected, +the+
driver can retry mapping with +fewer+-less- vectors, or disable MSI-X.
I really liked the conversational style: standards can be intimidating and
unfriendly documents if they concentrate too much on partitioning all
information into precise sections.
That makes it 0.8.6. I will re-read the entire document for consistency
before releasing 0.9.
Thanks!
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: markmc@redhat.com, kvm@vger.kernel.org, qemu-devel@nongnu.org,
virtualization@lists.linux-foundation.org
Subject: [Qemu-devel] Re: [PATCH] virtio-spec: document MSI-X
Date: Fri, 12 Feb 2010 20:17:55 +1030 [thread overview]
Message-ID: <201002122017.55536.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20100211172236.GA20357@redhat.com>
On Fri, 12 Feb 2010 03:52:36 am Michael S. Tsirkin wrote:
> This documents MSI-X support in virtio.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Wow, great!
I reworked one paragraph for better grammar. Mainly adding "the":
(pseudo-patch):
Devices report such failures by returning +the+ NO_VECTOR value
when the relevant Vector field is read. After mapping an event to vector,
+the+ driver must verify success by reading the Vector field value: on
success, +the+ previously written value is returned-;-+, and+ on failure,
NO_VECTOR -value- is returned. If +a+ mapping failure is detected, +the+
driver can retry mapping with +fewer+-less- vectors, or disable MSI-X.
I really liked the conversational style: standards can be intimidating and
unfriendly documents if they concentrate too much on partitioning all
information into precise sections.
That makes it 0.8.6. I will re-read the entire document for consistency
before releasing 0.9.
Thanks!
Rusty.
next prev parent reply other threads:[~2010-02-12 9:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-11 17:22 [PATCH] virtio-spec: document MSI-X Michael S. Tsirkin
2010-02-11 17:22 ` [Qemu-devel] " Michael S. Tsirkin
2010-02-12 9:47 ` Rusty Russell
2010-02-12 9:47 ` Rusty Russell [this message]
2010-02-12 9:47 ` [Qemu-devel] " Rusty Russell
2010-02-12 10:47 ` Michael S. Tsirkin
2010-02-12 10:47 ` [Qemu-devel] " Michael S. Tsirkin
2010-02-12 10:47 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2010-02-11 17:22 Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002122017.55536.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=anthony@codemonkey.ws \
--cc=kvm@vger.kernel.org \
--cc=markmc@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.