* [PATCH][user-cr]: ckptinfo: Have -v imply -p option
@ 2010-02-19 19:36 Sukadev Bhattiprolu
[not found] ` <20100219193643.GA332-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Sukadev Bhattiprolu @ 2010-02-19 19:36 UTC (permalink / raw)
To: Oren Laadan; +Cc: Containers
Do we even need the -p option ? It is not used without the -v at present.
Can we drop the -p and have -v print filepos always ?
---
From: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Date: Fri, 19 Feb 2010 11:19:08 -0800
Subject: [PATCH 1/1] ckptinfo: Have -v imply -p
When the -v is chosen, user wants verbose debug information. The
filepos would be useful to correlate with the kernel debug messages
and does not clutter the output.
Signed-off-by: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
---
ckptinfo.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/ckptinfo.c b/ckptinfo.c
index 6859742..be91b80 100644
--- a/ckptinfo.c
+++ b/ckptinfo.c
@@ -135,7 +135,7 @@ int main(int argc, char *argv[])
if (args.verbose)
__verbose = 1;
- if (args.position)
+ if (args.position || args.verbose)
__position = 1;
argc -= optind;
--
1.6.6.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][user-cr]: ckptinfo: Have -v imply -p option
[not found] ` <20100219193643.GA332-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
@ 2010-02-22 22:52 ` Oren Laadan
0 siblings, 0 replies; 2+ messages in thread
From: Oren Laadan @ 2010-02-22 22:52 UTC (permalink / raw)
To: Sukadev Bhattiprolu; +Cc: Containers
Sukadev Bhattiprolu wrote:
> Do we even need the -p option ? It is not used without the -v at present.
> Can we drop the -p and have -v print filepos always ?
Ok. I'll do that.
Oren.
>
> ---
> From: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
> Date: Fri, 19 Feb 2010 11:19:08 -0800
> Subject: [PATCH 1/1] ckptinfo: Have -v imply -p
>
> When the -v is chosen, user wants verbose debug information. The
> filepos would be useful to correlate with the kernel debug messages
> and does not clutter the output.
>
> Signed-off-by: Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
> ---
> ckptinfo.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/ckptinfo.c b/ckptinfo.c
> index 6859742..be91b80 100644
> --- a/ckptinfo.c
> +++ b/ckptinfo.c
> @@ -135,7 +135,7 @@ int main(int argc, char *argv[])
>
> if (args.verbose)
> __verbose = 1;
> - if (args.position)
> + if (args.position || args.verbose)
> __position = 1;
>
> argc -= optind;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-22 22:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-19 19:36 [PATCH][user-cr]: ckptinfo: Have -v imply -p option Sukadev Bhattiprolu
[not found] ` <20100219193643.GA332-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-02-22 22:52 ` Oren Laadan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.