From: Vasily Khoruzhick <anarsoul@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: ben-linux@fluff.org, linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH 2/4] s3c24xx_ts: report touch only when stylus is down
Date: Sun, 21 Feb 2010 11:05:26 +0200 [thread overview]
Message-ID: <201002211105.30079.anarsoul@gmail.com> (raw)
In-Reply-To: <20100221073512.GA18298@core.coreip.homeip.net>
[-- Attachment #1.1: Type: Text/Plain, Size: 713 bytes --]
В сообщении от 21 февраля 2010 09:35:13 автор Dmitry Torokhov написал:
> Applied, thank you Vasily.
>
> One more thing though - why do we need that timer to report input events
> and reschedule ADC conversions? It looks like it is not really needed.
> Could you please give a try to the patch below?
>
> Thanks!
Timer is used to avoid reporting input events in interrupt context (select
callback is called from s3c_adc_try and from s3c_adc_irq), Is it safe to call
input_report_abs/input_report_key from interrupt context? Anyway, driver
doesn't work for me with this patch (it works as mouse, but it doesn't as
touchscreen through tslib)
Regards,
Vasily
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: anarsoul@gmail.com (Vasily Khoruzhick)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] s3c24xx_ts: report touch only when stylus is down
Date: Sun, 21 Feb 2010 11:05:26 +0200 [thread overview]
Message-ID: <201002211105.30079.anarsoul@gmail.com> (raw)
In-Reply-To: <20100221073512.GA18298@core.coreip.homeip.net>
? ????????? ?? 21 ??????? 2010 09:35:13 ????? Dmitry Torokhov ???????:
> Applied, thank you Vasily.
>
> One more thing though - why do we need that timer to report input events
> and reschedule ADC conversions? It looks like it is not really needed.
> Could you please give a try to the patch below?
>
> Thanks!
Timer is used to avoid reporting input events in interrupt context (select
callback is called from s3c_adc_try and from s3c_adc_irq), Is it safe to call
input_report_abs/input_report_key from interrupt context? Anyway, driver
doesn't work for me with this patch (it works as mouse, but it doesn't as
touchscreen through tslib)
Regards,
Vasily
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100221/461a0fd3/attachment.sig>
next prev parent reply other threads:[~2010-02-21 9:05 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 16:32 [PATCH 0/4] s3c24xx_ts driver fixes Vasily Khoruzhick
2010-02-18 16:32 ` Vasily Khoruzhick
2010-02-18 16:32 ` [PATCH 1/4] Add resources description for s3c24xx ts driver Vasily Khoruzhick
2010-02-18 16:32 ` Vasily Khoruzhick
2010-02-21 23:12 ` Ben Dooks
2010-02-18 16:32 ` [PATCH 2/4] s3c24xx_ts: report touch only when stylus is down Vasily Khoruzhick
2010-02-18 16:32 ` Vasily Khoruzhick
2010-02-19 9:17 ` Dmitry Torokhov
2010-02-19 9:17 ` Dmitry Torokhov
2010-02-19 10:02 ` Vasily Khoruzhick
2010-02-19 10:02 ` Vasily Khoruzhick
2010-02-21 7:35 ` Dmitry Torokhov
2010-02-21 7:35 ` Dmitry Torokhov
2010-02-21 9:05 ` Vasily Khoruzhick [this message]
2010-02-21 9:05 ` Vasily Khoruzhick
2010-02-21 9:41 ` Dmitry Torokhov
2010-02-21 9:41 ` Dmitry Torokhov
2010-02-21 10:10 ` Vasily Khoruzhick
2010-02-21 10:10 ` Vasily Khoruzhick
2010-02-21 10:28 ` Dmitry Torokhov
2010-02-21 10:28 ` Dmitry Torokhov
2010-02-21 10:33 ` Vasily Khoruzhick
2010-02-21 10:33 ` Vasily Khoruzhick
2010-02-21 14:27 ` Nelson Castillo
2010-02-21 21:44 ` Vasily Khoruzhick
2010-02-21 22:51 ` Dmitry Torokhov
2010-02-21 22:58 ` Vasily Khoruzhick
2010-02-22 7:14 ` Dmitry Torokhov
2010-02-22 7:14 ` Dmitry Torokhov
2010-02-22 8:58 ` Vasily Khoruzhick
2010-02-22 8:58 ` Vasily Khoruzhick
2010-02-22 9:03 ` Vasily Khoruzhick
2010-02-22 9:03 ` Vasily Khoruzhick
2010-02-18 16:32 ` [PATCH 3/4] s3c24xx_adc: disable/enable IRQ on suspend/resume Vasily Khoruzhick
2010-02-18 16:32 ` Vasily Khoruzhick
2010-02-21 23:12 ` Ben Dooks
2010-02-18 16:32 ` [PATCH 4/4] s3c24xx_ts: re-enable IRQ on resume Vasily Khoruzhick
2010-02-18 16:32 ` Vasily Khoruzhick
2010-02-19 9:05 ` Dmitry Torokhov
2010-02-19 9:05 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002211105.30079.anarsoul@gmail.com \
--to=anarsoul@gmail.com \
--cc=ben-linux@fluff.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.