From: Vasily Khoruzhick <anarsoul@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, ben-linux@fluff.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH 2/4] s3c24xx_ts: report touch only when stylus is down
Date: Sun, 21 Feb 2010 12:10:08 +0200 [thread overview]
Message-ID: <201002211210.12306.anarsoul@gmail.com> (raw)
In-Reply-To: <20100221094151.GC18298@core.coreip.homeip.net>
[-- Attachment #1: Type: Text/Plain, Size: 689 bytes --]
В сообщении от 21 февраля 2010 11:41:51 автор Dmitry Torokhov написал:
> > Timer is used to avoid reporting input events in interrupt context
> > (select callback is called from s3c_adc_try and from s3c_adc_irq),
> ??? This is quite a novel concept for me...
I think so, as I don't see any other reasons to use timer :)
> > Anyway, driver
> > doesn't work for me with this patch (it works as mouse, but it doesn't as
> > touchscreen through tslib)
>
> Hmm, does evtest utility report all expected events?
evtest shows that driver starts event flood on first touch, i.e. it doesn't
stop to emit event when stylus is up.
Regards
Vasily
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: anarsoul@gmail.com (Vasily Khoruzhick)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] s3c24xx_ts: report touch only when stylus is down
Date: Sun, 21 Feb 2010 12:10:08 +0200 [thread overview]
Message-ID: <201002211210.12306.anarsoul@gmail.com> (raw)
In-Reply-To: <20100221094151.GC18298@core.coreip.homeip.net>
? ????????? ?? 21 ??????? 2010 11:41:51 ????? Dmitry Torokhov ???????:
> > Timer is used to avoid reporting input events in interrupt context
> > (select callback is called from s3c_adc_try and from s3c_adc_irq),
> ??? This is quite a novel concept for me...
I think so, as I don't see any other reasons to use timer :)
> > Anyway, driver
> > doesn't work for me with this patch (it works as mouse, but it doesn't as
> > touchscreen through tslib)
>
> Hmm, does evtest utility report all expected events?
evtest shows that driver starts event flood on first touch, i.e. it doesn't
stop to emit event when stylus is up.
Regards
Vasily
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100221/70e2ae59/attachment.sig>
next prev parent reply other threads:[~2010-02-21 10:10 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 16:32 [PATCH 0/4] s3c24xx_ts driver fixes Vasily Khoruzhick
2010-02-18 16:32 ` Vasily Khoruzhick
2010-02-18 16:32 ` [PATCH 1/4] Add resources description for s3c24xx ts driver Vasily Khoruzhick
2010-02-18 16:32 ` Vasily Khoruzhick
2010-02-21 23:12 ` Ben Dooks
2010-02-18 16:32 ` [PATCH 2/4] s3c24xx_ts: report touch only when stylus is down Vasily Khoruzhick
2010-02-18 16:32 ` Vasily Khoruzhick
2010-02-19 9:17 ` Dmitry Torokhov
2010-02-19 9:17 ` Dmitry Torokhov
2010-02-19 10:02 ` Vasily Khoruzhick
2010-02-19 10:02 ` Vasily Khoruzhick
2010-02-21 7:35 ` Dmitry Torokhov
2010-02-21 7:35 ` Dmitry Torokhov
2010-02-21 9:05 ` Vasily Khoruzhick
2010-02-21 9:05 ` Vasily Khoruzhick
2010-02-21 9:41 ` Dmitry Torokhov
2010-02-21 9:41 ` Dmitry Torokhov
2010-02-21 10:10 ` Vasily Khoruzhick [this message]
2010-02-21 10:10 ` Vasily Khoruzhick
2010-02-21 10:28 ` Dmitry Torokhov
2010-02-21 10:28 ` Dmitry Torokhov
2010-02-21 10:33 ` Vasily Khoruzhick
2010-02-21 10:33 ` Vasily Khoruzhick
2010-02-21 14:27 ` Nelson Castillo
2010-02-21 21:44 ` Vasily Khoruzhick
2010-02-21 22:51 ` Dmitry Torokhov
2010-02-21 22:58 ` Vasily Khoruzhick
2010-02-22 7:14 ` Dmitry Torokhov
2010-02-22 7:14 ` Dmitry Torokhov
2010-02-22 8:58 ` Vasily Khoruzhick
2010-02-22 8:58 ` Vasily Khoruzhick
2010-02-22 9:03 ` Vasily Khoruzhick
2010-02-22 9:03 ` Vasily Khoruzhick
2010-02-18 16:32 ` [PATCH 3/4] s3c24xx_adc: disable/enable IRQ on suspend/resume Vasily Khoruzhick
2010-02-18 16:32 ` Vasily Khoruzhick
2010-02-21 23:12 ` Ben Dooks
2010-02-18 16:32 ` [PATCH 4/4] s3c24xx_ts: re-enable IRQ on resume Vasily Khoruzhick
2010-02-18 16:32 ` Vasily Khoruzhick
2010-02-19 9:05 ` Dmitry Torokhov
2010-02-19 9:05 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002211210.12306.anarsoul@gmail.com \
--to=anarsoul@gmail.com \
--cc=ben-linux@fluff.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.