All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] mca: remove some dead code
Date: Mon, 22 Feb 2010 04:54:45 +0000	[thread overview]
Message-ID: <20100222045445.GA4853@bicker> (raw)

There are two return statements in a row.  The first return statement is
the correct one.  For the unused return statement, it is the 
mca_device_read_stored_pos() which returns mca_dev->pos[reg];

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/drivers/mca/mca-device.c b/drivers/mca/mca-device.c
index e7adf89..ff078f4 100644
--- a/drivers/mca/mca-device.c
+++ b/drivers/mca/mca-device.c
@@ -65,8 +65,6 @@ unsigned char mca_device_read_pos(struct mca_device *mca_dev, int reg)
 	struct mca_bus *mca_bus = to_mca_bus(mca_dev->dev.parent);
 
 	return mca_bus->f.mca_read_pos(mca_dev, reg);
-
-	return 	mca_dev->pos[reg];
 }
 EXPORT_SYMBOL(mca_device_read_pos);
 

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] mca: remove some dead code
Date: Mon, 22 Feb 2010 07:54:45 +0300	[thread overview]
Message-ID: <20100222045445.GA4853@bicker> (raw)

There are two return statements in a row.  The first return statement is
the correct one.  For the unused return statement, it is the 
mca_device_read_stored_pos() which returns mca_dev->pos[reg];

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/drivers/mca/mca-device.c b/drivers/mca/mca-device.c
index e7adf89..ff078f4 100644
--- a/drivers/mca/mca-device.c
+++ b/drivers/mca/mca-device.c
@@ -65,8 +65,6 @@ unsigned char mca_device_read_pos(struct mca_device *mca_dev, int reg)
 	struct mca_bus *mca_bus = to_mca_bus(mca_dev->dev.parent);
 
 	return mca_bus->f.mca_read_pos(mca_dev, reg);
-
-	return 	mca_dev->pos[reg];
 }
 EXPORT_SYMBOL(mca_device_read_pos);
 

             reply	other threads:[~2010-02-22  4:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-22  4:54 Dan Carpenter [this message]
2010-02-22  4:54 ` [patch] mca: remove some dead code Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100222045445.GA4853@bicker \
    --to=error27@gmail.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.