* [patch] mca: remove some dead code
@ 2010-02-22 4:54 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2010-02-22 4:54 UTC (permalink / raw)
To: James Bottomley; +Cc: linux-kernel, kernel-janitors
There are two return statements in a row. The first return statement is
the correct one. For the unused return statement, it is the
mca_device_read_stored_pos() which returns mca_dev->pos[reg];
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/mca/mca-device.c b/drivers/mca/mca-device.c
index e7adf89..ff078f4 100644
--- a/drivers/mca/mca-device.c
+++ b/drivers/mca/mca-device.c
@@ -65,8 +65,6 @@ unsigned char mca_device_read_pos(struct mca_device *mca_dev, int reg)
struct mca_bus *mca_bus = to_mca_bus(mca_dev->dev.parent);
return mca_bus->f.mca_read_pos(mca_dev, reg);
-
- return mca_dev->pos[reg];
}
EXPORT_SYMBOL(mca_device_read_pos);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [patch] mca: remove some dead code
@ 2010-02-22 4:54 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2010-02-22 4:54 UTC (permalink / raw)
To: James Bottomley; +Cc: linux-kernel, kernel-janitors
There are two return statements in a row. The first return statement is
the correct one. For the unused return statement, it is the
mca_device_read_stored_pos() which returns mca_dev->pos[reg];
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/mca/mca-device.c b/drivers/mca/mca-device.c
index e7adf89..ff078f4 100644
--- a/drivers/mca/mca-device.c
+++ b/drivers/mca/mca-device.c
@@ -65,8 +65,6 @@ unsigned char mca_device_read_pos(struct mca_device *mca_dev, int reg)
struct mca_bus *mca_bus = to_mca_bus(mca_dev->dev.parent);
return mca_bus->f.mca_read_pos(mca_dev, reg);
-
- return mca_dev->pos[reg];
}
EXPORT_SYMBOL(mca_device_read_pos);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-22 4:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-22 4:54 [patch] mca: remove some dead code Dan Carpenter
2010-02-22 4:54 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.