From: Johannes Weiner <hannes@cmpxchg.org>
To: Rik van Riel <riel@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Minchan Kim <minchan.kim@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: mm: used-once mapped file page detection
Date: Sun, 28 Feb 2010 21:36:27 +0100 [thread overview]
Message-ID: <20100228203627.GA21128@cmpxchg.org> (raw)
In-Reply-To: <4B8AAC9A.10203@redhat.com>
On Sun, Feb 28, 2010 at 12:49:14PM -0500, Rik van Riel wrote:
> On 02/26/2010 09:32 AM, Johannes Weiner wrote:
> >On Wed, Feb 24, 2010 at 01:39:46PM -0800, Andrew Morton wrote:
> >>On Mon, 22 Feb 2010 20:49:07 +0100 Johannes Weiner<hannes@cmpxchg.org>
> >>wrote:
> >>
> >>>This patch makes the VM be more careful about activating mapped file
> >>>pages in the first place. The minimum granted lifetime without
> >>>another memory access becomes an inactive list cycle instead of the
> >>>full memory cycle, which is more natural given the mentioned loads.
> >>
> >>iirc from a long time ago, the insta-activation of mapped pages was
> >>done because people were getting peeved about having their interactive
> >>applications (X, browser, etc) getting paged out, and bumping the pages
> >>immediately was found to help with this subjective problem.
> >>
> >>So it was a latency issue more than a throughput issue. I wouldn't be
> >>surprised if we get some complaints from people for the same reasons as
> >>a result of this patch.
> >
> >Agreed. Although we now have other things in place to protect them once
> >they are active (VM_EXEC protection, lazy active list scanning).
>
> You think we'll need VM_EXEC protection on the inactive list
> after your changes?
So far I personally did not experience anything that would indicate the
need for it. But I would consider it an option if Andrew's worries turned
out to be true.
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Rik van Riel <riel@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Minchan Kim <minchan.kim@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: mm: used-once mapped file page detection
Date: Sun, 28 Feb 2010 21:36:27 +0100 [thread overview]
Message-ID: <20100228203627.GA21128@cmpxchg.org> (raw)
In-Reply-To: <4B8AAC9A.10203@redhat.com>
On Sun, Feb 28, 2010 at 12:49:14PM -0500, Rik van Riel wrote:
> On 02/26/2010 09:32 AM, Johannes Weiner wrote:
> >On Wed, Feb 24, 2010 at 01:39:46PM -0800, Andrew Morton wrote:
> >>On Mon, 22 Feb 2010 20:49:07 +0100 Johannes Weiner<hannes@cmpxchg.org>
> >>wrote:
> >>
> >>>This patch makes the VM be more careful about activating mapped file
> >>>pages in the first place. The minimum granted lifetime without
> >>>another memory access becomes an inactive list cycle instead of the
> >>>full memory cycle, which is more natural given the mentioned loads.
> >>
> >>iirc from a long time ago, the insta-activation of mapped pages was
> >>done because people were getting peeved about having their interactive
> >>applications (X, browser, etc) getting paged out, and bumping the pages
> >>immediately was found to help with this subjective problem.
> >>
> >>So it was a latency issue more than a throughput issue. I wouldn't be
> >>surprised if we get some complaints from people for the same reasons as
> >>a result of this patch.
> >
> >Agreed. Although we now have other things in place to protect them once
> >they are active (VM_EXEC protection, lazy active list scanning).
>
> You think we'll need VM_EXEC protection on the inactive list
> after your changes?
So far I personally did not experience anything that would indicate the
need for it. But I would consider it an option if Andrew's worries turned
out to be true.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-02-28 20:36 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 19:49 mm: used-once mapped file page detection Johannes Weiner
2010-02-22 19:49 ` Johannes Weiner
2010-02-22 19:49 ` [patch 1/3] vmscan: factor out page reference checks Johannes Weiner
2010-02-22 19:49 ` Johannes Weiner
2010-02-22 20:27 ` Rik van Riel
2010-02-22 20:27 ` Rik van Riel
2010-02-23 13:38 ` Minchan Kim
2010-02-23 13:38 ` Minchan Kim
2010-02-23 14:21 ` Johannes Weiner
2010-02-23 14:21 ` Johannes Weiner
2010-02-23 14:31 ` Rik van Riel
2010-02-23 14:31 ` Rik van Riel
2010-02-23 14:44 ` Minchan Kim
2010-02-23 14:44 ` Minchan Kim
2010-02-23 15:40 ` Johannes Weiner
2010-02-23 15:40 ` Johannes Weiner
2010-02-23 16:04 ` Minchan Kim
2010-02-23 16:04 ` Minchan Kim
2010-02-22 19:49 ` [patch 2/3] vmscan: drop page_mapping_inuse() Johannes Weiner
2010-02-22 19:49 ` Johannes Weiner
2010-02-22 20:28 ` Rik van Riel
2010-02-22 20:28 ` Rik van Riel
2010-02-23 14:03 ` Minchan Kim
2010-02-23 14:03 ` Minchan Kim
2010-02-23 14:32 ` Johannes Weiner
2010-02-23 14:32 ` Johannes Weiner
2010-02-23 14:48 ` Minchan Kim
2010-02-23 14:48 ` Minchan Kim
2010-02-22 19:49 ` [patch 3/3] vmscan: detect mapped file pages used only once Johannes Weiner
2010-02-22 19:49 ` Johannes Weiner
2010-02-22 20:34 ` Rik van Riel
2010-02-22 20:34 ` Rik van Riel
2010-02-23 15:03 ` Minchan Kim
2010-02-23 15:03 ` Minchan Kim
2010-02-23 15:45 ` Johannes Weiner
2010-02-23 15:45 ` Johannes Weiner
2010-02-24 21:39 ` mm: used-once mapped file page detection Andrew Morton
2010-02-24 21:39 ` Andrew Morton
2010-02-26 14:32 ` Johannes Weiner
2010-02-26 14:32 ` Johannes Weiner
2010-02-28 17:49 ` Rik van Riel
2010-02-28 17:49 ` Rik van Riel
2010-02-28 20:36 ` Johannes Weiner [this message]
2010-02-28 20:36 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100228203627.GA21128@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.