From: Rik van Riel <riel@redhat.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Minchan Kim <minchan.kim@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 1/3] vmscan: factor out page reference checks
Date: Tue, 23 Feb 2010 09:31:08 -0500 [thread overview]
Message-ID: <4B83E6AC.8030306@redhat.com> (raw)
In-Reply-To: <20100223142158.GA29762@cmpxchg.org>
On 02/23/2010 09:21 AM, Johannes Weiner wrote:
> From: Johannes Weiner<hannes@cmpxchg.org>
> Subject: vmscan: improve comment on mlocked page in reclaim
>
> Signed-off-by: Johannes Weiner<hannes@cmpxchg.org>
> ---
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 674a78b..819fff7 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -578,7 +578,10 @@ static enum page_references page_check_references(struct page *page,
> if (sc->order> PAGE_ALLOC_COSTLY_ORDER)
> return PAGEREF_RECLAIM;
>
> - /* Mlock lost isolation race - let try_to_unmap() handle it */
> + /*
> + * Mlock lost the isolation race with us. Let try_to_unmap()
> + * move the page to the unevictable list.
> + */
> if (vm_flags& VM_LOCKED)
> return PAGEREF_RECLAIM;
Reviewed-by: Rik van Riel <riel@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Minchan Kim <minchan.kim@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 1/3] vmscan: factor out page reference checks
Date: Tue, 23 Feb 2010 09:31:08 -0500 [thread overview]
Message-ID: <4B83E6AC.8030306@redhat.com> (raw)
In-Reply-To: <20100223142158.GA29762@cmpxchg.org>
On 02/23/2010 09:21 AM, Johannes Weiner wrote:
> From: Johannes Weiner<hannes@cmpxchg.org>
> Subject: vmscan: improve comment on mlocked page in reclaim
>
> Signed-off-by: Johannes Weiner<hannes@cmpxchg.org>
> ---
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 674a78b..819fff7 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -578,7 +578,10 @@ static enum page_references page_check_references(struct page *page,
> if (sc->order> PAGE_ALLOC_COSTLY_ORDER)
> return PAGEREF_RECLAIM;
>
> - /* Mlock lost isolation race - let try_to_unmap() handle it */
> + /*
> + * Mlock lost the isolation race with us. Let try_to_unmap()
> + * move the page to the unevictable list.
> + */
> if (vm_flags& VM_LOCKED)
> return PAGEREF_RECLAIM;
Reviewed-by: Rik van Riel <riel@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-02-23 14:31 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 19:49 mm: used-once mapped file page detection Johannes Weiner
2010-02-22 19:49 ` Johannes Weiner
2010-02-22 19:49 ` [patch 1/3] vmscan: factor out page reference checks Johannes Weiner
2010-02-22 19:49 ` Johannes Weiner
2010-02-22 20:27 ` Rik van Riel
2010-02-22 20:27 ` Rik van Riel
2010-02-23 13:38 ` Minchan Kim
2010-02-23 13:38 ` Minchan Kim
2010-02-23 14:21 ` Johannes Weiner
2010-02-23 14:21 ` Johannes Weiner
2010-02-23 14:31 ` Rik van Riel [this message]
2010-02-23 14:31 ` Rik van Riel
2010-02-23 14:44 ` Minchan Kim
2010-02-23 14:44 ` Minchan Kim
2010-02-23 15:40 ` Johannes Weiner
2010-02-23 15:40 ` Johannes Weiner
2010-02-23 16:04 ` Minchan Kim
2010-02-23 16:04 ` Minchan Kim
2010-02-22 19:49 ` [patch 2/3] vmscan: drop page_mapping_inuse() Johannes Weiner
2010-02-22 19:49 ` Johannes Weiner
2010-02-22 20:28 ` Rik van Riel
2010-02-22 20:28 ` Rik van Riel
2010-02-23 14:03 ` Minchan Kim
2010-02-23 14:03 ` Minchan Kim
2010-02-23 14:32 ` Johannes Weiner
2010-02-23 14:32 ` Johannes Weiner
2010-02-23 14:48 ` Minchan Kim
2010-02-23 14:48 ` Minchan Kim
2010-02-22 19:49 ` [patch 3/3] vmscan: detect mapped file pages used only once Johannes Weiner
2010-02-22 19:49 ` Johannes Weiner
2010-02-22 20:34 ` Rik van Riel
2010-02-22 20:34 ` Rik van Riel
2010-02-23 15:03 ` Minchan Kim
2010-02-23 15:03 ` Minchan Kim
2010-02-23 15:45 ` Johannes Weiner
2010-02-23 15:45 ` Johannes Weiner
2010-02-24 21:39 ` mm: used-once mapped file page detection Andrew Morton
2010-02-24 21:39 ` Andrew Morton
2010-02-26 14:32 ` Johannes Weiner
2010-02-26 14:32 ` Johannes Weiner
2010-02-28 17:49 ` Rik van Riel
2010-02-28 17:49 ` Rik van Riel
2010-02-28 20:36 ` Johannes Weiner
2010-02-28 20:36 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B83E6AC.8030306@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.