From: Ming Lei <tom.leiming@gmail.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k: decrease size of ath9k.ko
Date: Mon, 1 Mar 2010 23:13:29 +0800 [thread overview]
Message-ID: <20100301231329.64e3dd3b@tom-lei> (raw)
In-Reply-To: <4B89E0D7.9020103@lwfinger.net>
WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <tom.leiming@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: lrodriguez@atheros.com, linux-wireless@vger.kernel.org,
ath9k-devel@lists.ath9k.org, linville@tuxdriver.com,
johannes@sipsolutions.net
Subject: Re: [PATCH] ath9k: decrease size of ath9k.ko
Date: Mon, 1 Mar 2010 23:13:29 +0800 [thread overview]
Message-ID: <20100301231329.64e3dd3b@tom-lei> (raw)
In-Reply-To: <4B89E0D7.9020103@lwfinger.net>
>From e74b075cdb143d45be9b371ee8a8e2dcfc15ab34 Mon Sep 17 00:00:00 2001
From: Ming Lei <tom.leiming@gmail.com>
Date: Sat, 27 Feb 2010 23:50:54 +0800
Subject: [PATCH] ath9k: decrease size of ath9k.ko
The patch defines the fields of 'valid_single_stream' and 'valid' in
struct ath_rate_table as char type, so decrease the size of ath9k.ko
about 2KB.
old ath9k.ko
[tom@tom-lei ath9k]$ size ath9k.ko
text data bss dec hex filename
69344 3080 168 72592 11b90 ath9k.ko
new ath9k.ko
[tom@tom-lei ath9k]$ size ath9k.ko
text data bss dec hex filename
67304 3080 168 70552 11398 ath9k.ko
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
---
This version takes Larry's suggestion to define 'valid_single_stream'
and 'valid' as u8 instead of char.
---
drivers/net/wireless/ath/ath9k/rc.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/rc.h b/drivers/net/wireless/ath/ath9k/rc.h
index 4f6d6fd..aeaaa88 100644
--- a/drivers/net/wireless/ath/ath9k/rc.h
+++ b/drivers/net/wireless/ath/ath9k/rc.h
@@ -110,8 +110,8 @@ struct ath_rate_table {
int rate_cnt;
int mcs_start;
struct {
- int valid;
- int valid_single_stream;
+ u8 valid;
+ u8 valid_single_stream;
u8 phy;
u32 ratekbps;
u32 user_ratekbps;
--
1.6.2.5
On Sat, 27 Feb 2010 21:19:51 -0600
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> On 02/27/2010 08:52 PM, Ming Lei wrote:
> > 2010/2/28 Larry Finger <Larry.Finger@lwfinger.net>:
> >> On 02/27/2010 10:56 AM, tom.leiming@gmail.com wrote:
> >>> From: Ming Lei <tom.leiming@gmail.com>
> >
> > Either 'char' or 'u8' is OK, since both has one-byte size, isn't it?
>
> It wasn't the size, but the content implied by the type.
next prev parent reply other threads:[~2010-03-01 15:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-27 16:56 [ath9k-devel] [PATCH] ath9k: decrease size of ath9k.ko tom.leiming at gmail.com
2010-02-27 16:56 ` tom.leiming
2010-02-27 17:10 ` [ath9k-devel] " Larry Finger
2010-02-27 17:10 ` Larry Finger
2010-02-28 2:52 ` [ath9k-devel] " Ming Lei
2010-02-28 2:52 ` Ming Lei
2010-02-28 3:19 ` [ath9k-devel] " Larry Finger
2010-02-28 3:19 ` Larry Finger
2010-03-01 15:13 ` Ming Lei [this message]
2010-03-01 15:13 ` Ming Lei
2010-03-03 5:02 ` [ath9k-devel] " Pavel Roskin
2010-03-03 5:02 ` Pavel Roskin
2010-03-04 0:54 ` [ath9k-devel] " Luis R. Rodriguez
2010-03-04 0:54 ` Luis R. Rodriguez
2010-03-06 14:47 ` [ath9k-devel] " Ming Lei
2010-03-06 14:47 ` Ming Lei
2010-03-01 12:19 ` [ath9k-devel] " Holger Schurig
2010-03-01 12:19 ` Holger Schurig
2010-03-10 23:52 ` [ath9k-devel] [stable] " Greg KH
2010-03-10 23:52 ` Greg KH
2010-03-11 0:42 ` [ath9k-devel] " Luis R. Rodriguez
2010-03-11 0:42 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100301231329.64e3dd3b@tom-lei \
--to=tom.leiming@gmail.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.