From: Andrew Morton <akpm@linux-foundation.org>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, wolfgang.mues@auerswald.de,
avictor.za@gmail.com
Subject: Re: [PATCH 4/7] mmc: at91_mci: use DMA buffer for read
Date: Tue, 2 Mar 2010 13:34:34 -0800 [thread overview]
Message-ID: <20100302133434.761df661.akpm@linux-foundation.org> (raw)
In-Reply-To: <0374bbdf963e39fc012ad7885f9036c00dbb4079.1267209149.git.nicolas.ferre@atmel.com>
On Fri, 26 Feb 2010 19:39:32 +0100
Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> + kunmap_atomic(((void *)sgbuffer)-sg->offset, KM_BIO_SRC_IRQ);
It's a feature of kunmap_atomic() that it will accept a pointer to any
location in the page. So the subtraction isn't strictly needed.
And if the subtraction is removed, the (void*) cast can also be removed.
WARNING: multiple messages have this Message-ID (diff)
From: akpm@linux-foundation.org (Andrew Morton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/7] mmc: at91_mci: use DMA buffer for read
Date: Tue, 2 Mar 2010 13:34:34 -0800 [thread overview]
Message-ID: <20100302133434.761df661.akpm@linux-foundation.org> (raw)
In-Reply-To: <0374bbdf963e39fc012ad7885f9036c00dbb4079.1267209149.git.nicolas.ferre@atmel.com>
On Fri, 26 Feb 2010 19:39:32 +0100
Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> + kunmap_atomic(((void *)sgbuffer)-sg->offset, KM_BIO_SRC_IRQ);
It's a feature of kunmap_atomic() that it will accept a pointer to any
location in the page. So the subtraction isn't strictly needed.
And if the subtraction is removed, the (void*) cast can also be removed.
next prev parent reply other threads:[~2010-03-02 21:35 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 18:39 [PATCH 1/7] mmc: at91_mci: fix pointer errors Nicolas Ferre
2010-03-01 17:44 ` Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-02-26 18:39 ` [PATCH 2/7] mmc: at91_mci: fix timeout errors Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-02-26 18:39 ` [PATCH 3/7] mmc: at91_mci: use one coherent DMA buffer Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-02-26 18:39 ` [PATCH 4/7] mmc: at91_mci: use DMA buffer for read Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-03-02 21:34 ` Andrew Morton [this message]
2010-03-02 21:34 ` Andrew Morton
2010-03-03 7:34 ` Wolfgang Mües
2010-03-03 7:34 ` Wolfgang Mües
2010-03-03 14:17 ` [PATCH] mmc: at91_mci: correct kunmap_atomic() Nicolas Ferre
2010-03-03 14:17 ` Nicolas Ferre
2010-02-26 18:39 ` [PATCH 5/7] mmc: at91_mci: enable large data blocks Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-02-26 18:39 ` [PATCH 6/7] mmc: at91_mci: Enable MMC_CAP_SDIO_IRQ only when it actually works Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-02-26 18:39 ` [PATCH 7/7] mmc: at91_mci: introduce per-mci-revision conditional code Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-02-26 20:20 ` [PATCH 1/7] mmc: at91_mci: fix pointer errors Dan Carpenter
2010-02-26 20:20 ` Dan Carpenter
2010-02-26 20:20 ` Dan Carpenter
2010-08-27 19:33 ` Chris Ball
2010-08-27 19:33 ` Chris Ball
2010-08-27 19:34 ` Chris Ball
2010-08-27 19:34 ` Chris Ball
2010-08-30 6:51 ` Wolfgang Mües
2010-08-30 6:51 ` Wolfgang Mües
2010-08-30 6:51 ` Wolfgang Mües
2010-08-29 21:39 ` Ryan Mallon
2010-08-29 21:39 ` Ryan Mallon
2010-08-30 6:56 ` Wolfgang Mües
2010-08-30 6:56 ` Wolfgang Mües
2010-08-30 6:56 ` Wolfgang Mües
2010-08-30 7:05 ` Ryan Mallon
2010-08-30 7:05 ` Ryan Mallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100302133434.761df661.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=avictor.za@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=wolfgang.mues@auerswald.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.