From: "Wolfgang Mües" <wolfgang.mues@auerswald.de>
To: Ryan Mallon <ryan@bluewatersys.com>
Cc: Chris Ball <cjb@laptop.org>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
avictor.za@gmail.com, akpm@linux-foundation.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/7] mmc: at91_mci: fix pointer errors
Date: Mon, 30 Aug 2010 08:56:01 +0200 [thread overview]
Message-ID: <4C7B5601.5060505@auerswald.de> (raw)
In-Reply-To: <4C7AD3A0.40607@bluewatersys.com>
Hi,
Am 29.08.2010 23:39, schrieb Ryan Mallon:
> I see this is already applied, but why all the type trickery here? Why
> not just:
>
> memcpy(dmabuf, sgbuffer, amount);
> dmabuf += amount / sizeof(dmabuf);
Because this is wrong?
Maybe you mean sizeof(*dmabuf)?
The exact style of the bug fix is not important, it's important that
it's fixed.
best regards
i. A. Wolfgang Muees
Hardware-Entwicklung
Leiter Pruefen & Layout
--
Auerswald Gesellschaft fuer Datensysteme mbH
Phone: +49 5306-9219-562
Fax: +49 5306-9200-94
--------------------------------------------------------------
Auerswald Gesellschaft fuer Datensysteme mbH,
Vor den Grashoefen 1, 38162 Cremlingen
Registriert beim AG Braunschweig HRB 7499
Geschäftsführer: Dipl-Ing. Gerhard Auerswald
WARNING: multiple messages have this Message-ID (diff)
From: wolfgang.mues@auerswald.de (Wolfgang Mües)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] mmc: at91_mci: fix pointer errors
Date: Mon, 30 Aug 2010 08:56:01 +0200 [thread overview]
Message-ID: <4C7B5601.5060505@auerswald.de> (raw)
In-Reply-To: <4C7AD3A0.40607@bluewatersys.com>
Hi,
Am 29.08.2010 23:39, schrieb Ryan Mallon:
> I see this is already applied, but why all the type trickery here? Why
> not just:
>
> memcpy(dmabuf, sgbuffer, amount);
> dmabuf += amount / sizeof(dmabuf);
Because this is wrong?
Maybe you mean sizeof(*dmabuf)?
The exact style of the bug fix is not important, it's important that
it's fixed.
best regards
i. A. Wolfgang Muees
Hardware-Entwicklung
Leiter Pruefen & Layout
--
Auerswald Gesellschaft fuer Datensysteme mbH
Phone: +49 5306-9219-562
Fax: +49 5306-9200-94
--------------------------------------------------------------
Auerswald Gesellschaft fuer Datensysteme mbH,
Vor den Grashoefen 1, 38162 Cremlingen
Registriert beim AG Braunschweig HRB 7499
Gesch?ftsf?hrer: Dipl-Ing. Gerhard Auerswald
WARNING: multiple messages have this Message-ID (diff)
From: "Wolfgang Mües" <wolfgang.mues@auerswald.de>
To: Ryan Mallon <ryan@bluewatersys.com>
Cc: Chris Ball <cjb@laptop.org>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
<linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<avictor.za@gmail.com>, <akpm@linux-foundation.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/7] mmc: at91_mci: fix pointer errors
Date: Mon, 30 Aug 2010 08:56:01 +0200 [thread overview]
Message-ID: <4C7B5601.5060505@auerswald.de> (raw)
In-Reply-To: <4C7AD3A0.40607@bluewatersys.com>
Hi,
Am 29.08.2010 23:39, schrieb Ryan Mallon:
> I see this is already applied, but why all the type trickery here? Why
> not just:
>
> memcpy(dmabuf, sgbuffer, amount);
> dmabuf += amount / sizeof(dmabuf);
Because this is wrong?
Maybe you mean sizeof(*dmabuf)?
The exact style of the bug fix is not important, it's important that
it's fixed.
best regards
i. A. Wolfgang Muees
Hardware-Entwicklung
Leiter Pruefen & Layout
--
Auerswald Gesellschaft fuer Datensysteme mbH
Phone: +49 5306-9219-562
Fax: +49 5306-9200-94
--------------------------------------------------------------
Auerswald Gesellschaft fuer Datensysteme mbH,
Vor den Grashoefen 1, 38162 Cremlingen
Registriert beim AG Braunschweig HRB 7499
Geschäftsführer: Dipl-Ing. Gerhard Auerswald
next prev parent reply other threads:[~2010-08-30 7:26 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 18:39 [PATCH 1/7] mmc: at91_mci: fix pointer errors Nicolas Ferre
2010-03-01 17:44 ` Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-02-26 18:39 ` [PATCH 2/7] mmc: at91_mci: fix timeout errors Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-02-26 18:39 ` [PATCH 3/7] mmc: at91_mci: use one coherent DMA buffer Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-02-26 18:39 ` [PATCH 4/7] mmc: at91_mci: use DMA buffer for read Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-03-02 21:34 ` Andrew Morton
2010-03-02 21:34 ` Andrew Morton
2010-03-03 7:34 ` Wolfgang Mües
2010-03-03 7:34 ` Wolfgang Mües
2010-03-03 14:17 ` [PATCH] mmc: at91_mci: correct kunmap_atomic() Nicolas Ferre
2010-03-03 14:17 ` Nicolas Ferre
2010-02-26 18:39 ` [PATCH 5/7] mmc: at91_mci: enable large data blocks Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-02-26 18:39 ` [PATCH 6/7] mmc: at91_mci: Enable MMC_CAP_SDIO_IRQ only when it actually works Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-02-26 18:39 ` [PATCH 7/7] mmc: at91_mci: introduce per-mci-revision conditional code Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-02-26 18:39 ` Nicolas Ferre
2010-02-26 20:20 ` [PATCH 1/7] mmc: at91_mci: fix pointer errors Dan Carpenter
2010-02-26 20:20 ` Dan Carpenter
2010-02-26 20:20 ` Dan Carpenter
2010-08-27 19:33 ` Chris Ball
2010-08-27 19:33 ` Chris Ball
2010-08-27 19:34 ` Chris Ball
2010-08-27 19:34 ` Chris Ball
2010-08-30 6:51 ` Wolfgang Mües
2010-08-30 6:51 ` Wolfgang Mües
2010-08-30 6:51 ` Wolfgang Mües
2010-08-29 21:39 ` Ryan Mallon
2010-08-29 21:39 ` Ryan Mallon
2010-08-30 6:56 ` Wolfgang Mües [this message]
2010-08-30 6:56 ` Wolfgang Mües
2010-08-30 6:56 ` Wolfgang Mües
2010-08-30 7:05 ` Ryan Mallon
2010-08-30 7:05 ` Ryan Mallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7B5601.5060505@auerswald.de \
--to=wolfgang.mues@auerswald.de \
--cc=akpm@linux-foundation.org \
--cc=avictor.za@gmail.com \
--cc=cjb@laptop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=ryan@bluewatersys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.