All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: "James E.J. Bottomley" <James.Bottomley@suse.de>,
	Karsten Keil <keil@b1-systems.de>,
	Magnus Damm <damm@opensource.se>,
	linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
	YOKOTA Hiroshi <yokota@netlab.is.tsukuba.ac.jp>
Subject: [patch] pcmcia: add important if statement
Date: Mon, 15 Mar 2010 08:25:10 +0000	[thread overview]
Message-ID: <20100315082510.GH18181@bicker> (raw)

There was a problem introduced in Jul 2008 by:
0e6f9d270840 pcmcia: use pcmcia_loop_config in scsi pcmcia drivers

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/drivers/scsi/pcmcia/nsp_cs.c b/drivers/scsi/pcmcia/nsp_cs.c
index c2341af..0212464 100644
--- a/drivers/scsi/pcmcia/nsp_cs.c
+++ b/drivers/scsi/pcmcia/nsp_cs.c
@@ -1717,6 +1717,7 @@ static int nsp_cs_config(struct pcmcia_device *link)
 	cfg_mem->data = data;
 
 	ret = pcmcia_loop_config(link, nsp_cs_config_check, cfg_mem);
+	if (ret)
 		goto cs_failed;
 
 	if (link->conf.Attributes & CONF_ENABLE_IRQ) {

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: "James E.J. Bottomley" <James.Bottomley@suse.de>,
	Karsten Keil <keil@b1-systems.de>,
	Magnus Damm <damm@opensource.se>,
	linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
	YOKOTA Hiroshi <yokota@netlab.is.tsukuba.ac.jp>
Subject: [patch] pcmcia: add important if statement
Date: Mon, 15 Mar 2010 11:25:10 +0300	[thread overview]
Message-ID: <20100315082510.GH18181@bicker> (raw)

There was a problem introduced in Jul 2008 by:
0e6f9d270840 pcmcia: use pcmcia_loop_config in scsi pcmcia drivers

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/drivers/scsi/pcmcia/nsp_cs.c b/drivers/scsi/pcmcia/nsp_cs.c
index c2341af..0212464 100644
--- a/drivers/scsi/pcmcia/nsp_cs.c
+++ b/drivers/scsi/pcmcia/nsp_cs.c
@@ -1717,6 +1717,7 @@ static int nsp_cs_config(struct pcmcia_device *link)
 	cfg_mem->data = data;
 
 	ret = pcmcia_loop_config(link, nsp_cs_config_check, cfg_mem);
+	if (ret)
 		goto cs_failed;
 
 	if (link->conf.Attributes & CONF_ENABLE_IRQ) {

             reply	other threads:[~2010-03-15  8:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-15  8:25 Dan Carpenter [this message]
2010-03-15  8:25 ` [patch] pcmcia: add important if statement Dan Carpenter
2010-03-15 13:53 ` Dominik Brodowski
2010-03-15 13:53   ` Dominik Brodowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100315082510.GH18181@bicker \
    --to=error27@gmail.com \
    --cc=James.Bottomley@suse.de \
    --cc=damm@opensource.se \
    --cc=keil@b1-systems.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=yokota@netlab.is.tsukuba.ac.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.