* [patch] pcmcia: add important if statement
@ 2010-03-15 8:25 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-03-15 8:25 UTC (permalink / raw)
To: Dominik Brodowski
Cc: James E.J. Bottomley, Karsten Keil, Magnus Damm, linux-scsi,
kernel-janitors, YOKOTA Hiroshi
There was a problem introduced in Jul 2008 by:
0e6f9d270840 pcmcia: use pcmcia_loop_config in scsi pcmcia drivers
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/scsi/pcmcia/nsp_cs.c b/drivers/scsi/pcmcia/nsp_cs.c
index c2341af..0212464 100644
--- a/drivers/scsi/pcmcia/nsp_cs.c
+++ b/drivers/scsi/pcmcia/nsp_cs.c
@@ -1717,6 +1717,7 @@ static int nsp_cs_config(struct pcmcia_device *link)
cfg_mem->data = data;
ret = pcmcia_loop_config(link, nsp_cs_config_check, cfg_mem);
+ if (ret)
goto cs_failed;
if (link->conf.Attributes & CONF_ENABLE_IRQ) {
^ permalink raw reply related [flat|nested] 4+ messages in thread* [patch] pcmcia: add important if statement
@ 2010-03-15 8:25 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-03-15 8:25 UTC (permalink / raw)
To: Dominik Brodowski
Cc: James E.J. Bottomley, Karsten Keil, Magnus Damm, linux-scsi,
kernel-janitors, YOKOTA Hiroshi
There was a problem introduced in Jul 2008 by:
0e6f9d270840 pcmcia: use pcmcia_loop_config in scsi pcmcia drivers
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/scsi/pcmcia/nsp_cs.c b/drivers/scsi/pcmcia/nsp_cs.c
index c2341af..0212464 100644
--- a/drivers/scsi/pcmcia/nsp_cs.c
+++ b/drivers/scsi/pcmcia/nsp_cs.c
@@ -1717,6 +1717,7 @@ static int nsp_cs_config(struct pcmcia_device *link)
cfg_mem->data = data;
ret = pcmcia_loop_config(link, nsp_cs_config_check, cfg_mem);
+ if (ret)
goto cs_failed;
if (link->conf.Attributes & CONF_ENABLE_IRQ) {
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch] pcmcia: add important if statement
2010-03-15 8:25 ` Dan Carpenter
@ 2010-03-15 13:53 ` Dominik Brodowski
-1 siblings, 0 replies; 4+ messages in thread
From: Dominik Brodowski @ 2010-03-15 13:53 UTC (permalink / raw)
To: Dan Carpenter
Cc: James E.J. Bottomley, Karsten Keil, Magnus Damm, linux-scsi,
kernel-janitors, YOKOTA Hiroshi
Dan,
thanks -- have merged your patch into my "urgent" branch which I'll push
upstream soon.
Best,
Dominik
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-03-15 13:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-15 8:25 [patch] pcmcia: add important if statement Dan Carpenter
2010-03-15 8:25 ` Dan Carpenter
2010-03-15 13:53 ` Dominik Brodowski
2010-03-15 13:53 ` Dominik Brodowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.