All of lore.kernel.org
 help / color / mirror / Atom feed
From: rabin@rab.in (Rabin Vincent)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/10] ftrace: allow building without frame pointers
Date: Tue, 16 Mar 2010 00:15:06 +0530	[thread overview]
Message-ID: <20100315184506.GA2303@debian> (raw)
In-Reply-To: <1268501792.3366.7.camel@localhost>

On Sat, Mar 13, 2010 at 12:36:32PM -0500, Steven Rostedt wrote:
> On Sat, 2010-03-13 at 12:19 +0530, Rabin Vincent wrote:
> >  ifdef CONFIG_FRAME_POINTER
> >  KBUILD_CFLAGS	+= -fno-omit-frame-pointer -fno-optimize-sibling-calls
> >  else
> > +# Some targets (ARM with Thumb2, for example), can't be built with frame
> > +# pointers.  For those, we don't have FUNCTION_TRACER automatically
> > +# select FRAME_POINTER.  However, FUNCTION_TRACER adds -pg, and this is
> > +# incompatible with -fomit-frame-pointer with current GCC, so we don't use
> > +# -fomit-frame-pointer with FUNCTION_TRACER.
> > +ifndef CONFIG_FUNCTION_TRACER
> >  KBUILD_CFLAGS	+= -fomit-frame-pointer
> 
> I believe this is correct, but have you tested this on other archs other
> than ARM? I can do it for x86 and PPC, but it will need to wait as those
> machines are currently performing stress tests.

I've tested the series on x86-64.

Note that this particular change will not currently affect other archs
since they still have the "select FRAME_POINTER" in FUNCTION_TRACER.

Rabin

WARNING: multiple messages have this Message-ID (diff)
From: Rabin Vincent <rabin@rab.in>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	"Frederic Weisbecker" <fweisbec@gmail.com>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Abhishek Sagar" <sagar.abhishek@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH 03/10] ftrace: allow building without frame pointers
Date: Tue, 16 Mar 2010 00:15:06 +0530	[thread overview]
Message-ID: <20100315184506.GA2303@debian> (raw)
In-Reply-To: <1268501792.3366.7.camel@localhost>

On Sat, Mar 13, 2010 at 12:36:32PM -0500, Steven Rostedt wrote:
> On Sat, 2010-03-13 at 12:19 +0530, Rabin Vincent wrote:
> >  ifdef CONFIG_FRAME_POINTER
> >  KBUILD_CFLAGS	+= -fno-omit-frame-pointer -fno-optimize-sibling-calls
> >  else
> > +# Some targets (ARM with Thumb2, for example), can't be built with frame
> > +# pointers.  For those, we don't have FUNCTION_TRACER automatically
> > +# select FRAME_POINTER.  However, FUNCTION_TRACER adds -pg, and this is
> > +# incompatible with -fomit-frame-pointer with current GCC, so we don't use
> > +# -fomit-frame-pointer with FUNCTION_TRACER.
> > +ifndef CONFIG_FUNCTION_TRACER
> >  KBUILD_CFLAGS	+= -fomit-frame-pointer
> 
> I believe this is correct, but have you tested this on other archs other
> than ARM? I can do it for x86 and PPC, but it will need to wait as those
> machines are currently performing stress tests.

I've tested the series on x86-64.

Note that this particular change will not currently affect other archs
since they still have the "select FRAME_POINTER" in FUNCTION_TRACER.

Rabin

  reply	other threads:[~2010-03-15 18:45 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-13  6:49 [PATCH 00/10] ARM: ftrace: cleanups, Thumb-2, and dynamic ftrace (v2) Rabin Vincent
2010-03-13  6:49 ` Rabin Vincent
2010-03-13  6:49 ` [PATCH 01/10] ARM: ftrace: clean up mcount assembly indentation Rabin Vincent
2010-03-13  6:49   ` Rabin Vincent
2010-03-13  6:49 ` [PATCH 02/10] ARM: ftrace: document mcount formats Rabin Vincent
2010-03-13  6:49   ` Rabin Vincent
2010-03-13  6:49 ` [PATCH 03/10] ftrace: allow building without frame pointers Rabin Vincent
2010-03-13  6:49   ` Rabin Vincent
2010-03-13 17:36   ` Steven Rostedt
2010-03-13 17:36     ` Steven Rostedt
2010-03-15 18:45     ` Rabin Vincent [this message]
2010-03-15 18:45       ` Rabin Vincent
2010-03-14 16:56   ` Steven Rostedt
2010-03-14 16:56     ` Steven Rostedt
2010-03-13  6:49 ` [PATCH 04/10] ARM: " Rabin Vincent
2010-03-13  6:49   ` Rabin Vincent
2010-03-13 17:38   ` Steven Rostedt
2010-03-13 17:38     ` Steven Rostedt
2010-03-14 16:56   ` Steven Rostedt
2010-03-14 16:56     ` Steven Rostedt
2010-03-17 16:16     ` Catalin Marinas
2010-03-17 16:16       ` Catalin Marinas
2010-03-13  6:49 ` [PATCH 05/10] ARM: ftrace: add ENDPROC annotations Rabin Vincent
2010-03-13  6:49   ` Rabin Vincent
2010-03-13  8:45   ` Russell King - ARM Linux
2010-03-13  8:45     ` Russell King - ARM Linux
2010-04-21 19:23     ` Rabin Vincent
2010-04-21 19:23       ` Rabin Vincent
2010-08-10 17:07       ` Catalin Marinas
2010-08-10 17:07         ` Catalin Marinas
2010-08-10 19:11         ` Rabin Vincent
2010-08-10 19:11           ` Rabin Vincent
2010-03-13  6:49 ` [PATCH 06/10] ARM: ftrace: add Thumb-2 support Rabin Vincent
2010-03-13  6:49   ` Rabin Vincent
2010-03-14 22:30   ` Catalin Marinas
2010-03-14 22:30     ` Catalin Marinas
2010-03-15 18:32     ` Rabin Vincent
2010-03-15 18:32       ` Rabin Vincent
2010-03-16 10:23   ` Catalin Marinas
2010-03-16 10:23     ` Catalin Marinas
2010-03-31 18:25     ` Rabin Vincent
2010-03-31 18:25       ` Rabin Vincent
2010-04-23 15:37       ` Catalin Marinas
2010-04-23 15:37         ` Catalin Marinas
2010-03-13  6:49 ` [PATCH 07/10] ftrace: pass KBUILD_CFLAGS to record_mcount.pl Rabin Vincent
2010-03-13  6:49   ` Rabin Vincent
2010-03-13 17:41   ` Steven Rostedt
2010-03-13 17:41     ` Steven Rostedt
2010-03-14 16:56   ` Steven Rostedt
2010-03-14 16:56     ` Steven Rostedt
2010-03-31 18:45     ` Rabin Vincent
2010-03-31 18:45       ` Rabin Vincent
2010-08-03 16:42   ` Rabin Vincent
2010-08-03 16:42     ` Rabin Vincent
2010-08-06 15:31     ` Frederic Weisbecker
2010-08-06 15:31       ` Frederic Weisbecker
2010-08-06 20:23     ` Steven Rostedt
2010-08-06 20:23       ` Steven Rostedt
2010-08-07  5:33       ` Rabin Vincent
2010-08-07  5:33         ` Rabin Vincent
2010-08-07 12:57         ` Steven Rostedt
2010-08-07 12:57           ` Steven Rostedt
2010-03-13  6:49 ` [PATCH 08/10] ARM: ftrace: fix and update dynamic ftrace Rabin Vincent
2010-03-13  6:49   ` Rabin Vincent
2010-03-13 17:42   ` Steven Rostedt
2010-03-13 17:42     ` Steven Rostedt
2010-03-14 16:56   ` Steven Rostedt
2010-03-14 16:56     ` Steven Rostedt
2010-03-13  6:49 ` [PATCH 09/10] ARM: ftrace: add Thumb-2 support to " Rabin Vincent
2010-03-13  6:49   ` Rabin Vincent
2010-03-13  6:49 ` [PATCH 10/10] ARM: ftrace: enable " Rabin Vincent
2010-03-13  6:49   ` Rabin Vincent
2010-04-21 19:26 ` [PATCH 00/10] ARM: ftrace: cleanups, Thumb-2, and dynamic ftrace (v2) Rabin Vincent
2010-04-21 19:26   ` Rabin Vincent
  -- strict thread matches above, loose matches on Subject: below --
2010-02-13 19:48 [PATCH 00/10] ARM: ftrace: cleanups, Thumb-2, and dynamic ftrace Rabin Vincent
2010-02-13 19:48 ` [PATCH 03/10] ftrace: allow building without frame pointers Rabin Vincent
2010-02-13 19:48   ` Rabin Vincent
2010-02-22 18:36   ` Frederic Weisbecker
2010-02-22 18:36     ` Frederic Weisbecker
2010-02-23 13:44   ` Steven Rostedt
2010-02-23 13:44     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100315184506.GA2303@debian \
    --to=rabin@rab.in \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.