All of lore.kernel.org
 help / color / mirror / Atom feed
From: rostedt@goodmis.org (Steven Rostedt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/10] ftrace: allow building without frame pointers
Date: Tue, 23 Feb 2010 08:44:42 -0500	[thread overview]
Message-ID: <1266932682.19540.15.camel@frodo> (raw)
In-Reply-To: <1266090518-31120-4-git-send-email-rabin@rab.in>

On Sun, 2010-02-14 at 01:18 +0530, Rabin Vincent wrote:
> With current gcc, compiling with both -pg and -fomit-frame-pointer is
> not allowed.  However, -pg can be used to build without actually
> specying -fno-omit-frame-pointer, upon which the defaut behaviour for
> the target will be used.
> 
> On ARM, it is not possible to build a Thumb-2 kernel with
> -fno-omit-frame-pointer (FRAME_POINTERS depends on !THUMB2_KERNEL). In
> order to support ftrace for Thumb-2, we need to be able to allow a
> combination of FUNCTION_TRACER and !FRAME_POINTER.  We do this by
> omitting -fomit-frame-pointer if ftrace is enabled.
> 
> Signed-off-by: Rabin Vincent <rabin@rab.in>
> ---
>  Makefile |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 67d6cff..72d90de 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -546,8 +546,11 @@ endif
>  ifdef CONFIG_FRAME_POINTER
>  KBUILD_CFLAGS	+= -fno-omit-frame-pointer -fno-optimize-sibling-calls
>  else
> +ifndef CONFIG_FUNCTION_TRACER

Is this needed? Selecting FUNCTION_TRACER also selects FRAME_POINTER,
which this change is in the else part of that #if.

-- Steve

> +# -fomit-frame-pointer is incompatible with -pg
>  KBUILD_CFLAGS	+= -fomit-frame-pointer
>  endif
> +endif
>  
>  ifdef CONFIG_DEBUG_INFO
>  KBUILD_CFLAGS	+= -g

WARNING: multiple messages have this Message-ID (diff)
From: Steven Rostedt <rostedt@goodmis.org>
To: Rabin Vincent <rabin@rab.in>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	"Frederic Weisbecker" <fweisbec@gmail.com>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Abhishek Sagar" <sagar.abhishek@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH 03/10] ftrace: allow building without frame pointers
Date: Tue, 23 Feb 2010 08:44:42 -0500	[thread overview]
Message-ID: <1266932682.19540.15.camel@frodo> (raw)
In-Reply-To: <1266090518-31120-4-git-send-email-rabin@rab.in>

On Sun, 2010-02-14 at 01:18 +0530, Rabin Vincent wrote:
> With current gcc, compiling with both -pg and -fomit-frame-pointer is
> not allowed.  However, -pg can be used to build without actually
> specying -fno-omit-frame-pointer, upon which the defaut behaviour for
> the target will be used.
> 
> On ARM, it is not possible to build a Thumb-2 kernel with
> -fno-omit-frame-pointer (FRAME_POINTERS depends on !THUMB2_KERNEL). In
> order to support ftrace for Thumb-2, we need to be able to allow a
> combination of FUNCTION_TRACER and !FRAME_POINTER.  We do this by
> omitting -fomit-frame-pointer if ftrace is enabled.
> 
> Signed-off-by: Rabin Vincent <rabin@rab.in>
> ---
>  Makefile |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 67d6cff..72d90de 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -546,8 +546,11 @@ endif
>  ifdef CONFIG_FRAME_POINTER
>  KBUILD_CFLAGS	+= -fno-omit-frame-pointer -fno-optimize-sibling-calls
>  else
> +ifndef CONFIG_FUNCTION_TRACER

Is this needed? Selecting FUNCTION_TRACER also selects FRAME_POINTER,
which this change is in the else part of that #if.

-- Steve

> +# -fomit-frame-pointer is incompatible with -pg
>  KBUILD_CFLAGS	+= -fomit-frame-pointer
>  endif
> +endif
>  
>  ifdef CONFIG_DEBUG_INFO
>  KBUILD_CFLAGS	+= -g


  parent reply	other threads:[~2010-02-23 13:44 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-13 19:48 [PATCH 00/10] ARM: ftrace: cleanups, Thumb-2, and dynamic ftrace Rabin Vincent
2010-02-13 19:48 ` Rabin Vincent
2010-02-13 19:48 ` [PATCH 01/10] ARM: ftrace: clean up mcount assembly indentation Rabin Vincent
2010-02-13 19:48   ` Rabin Vincent
2010-02-13 20:18   ` Uwe Kleine-König
2010-02-13 20:18     ` Uwe Kleine-König
2010-02-22 18:36   ` Frederic Weisbecker
2010-02-22 18:36     ` Frederic Weisbecker
2010-02-13 19:48 ` [PATCH 02/10] ARM: ftrace: document mcount formats Rabin Vincent
2010-02-13 19:48   ` Rabin Vincent
2010-02-13 20:37   ` Uwe Kleine-König
2010-02-13 20:37     ` Uwe Kleine-König
2010-02-22 18:06     ` Rabin Vincent
2010-02-22 18:06       ` Rabin Vincent
2010-02-22 19:20       ` Uwe Kleine-König
2010-02-22 19:20         ` Uwe Kleine-König
2010-02-23 19:42         ` Rabin Vincent
2010-02-23 19:42           ` Rabin Vincent
2010-02-23 20:27           ` Uwe Kleine-König
2010-02-23 20:27             ` Uwe Kleine-König
2010-02-22 18:41   ` Frederic Weisbecker
2010-02-22 18:41     ` Frederic Weisbecker
2010-02-13 19:48 ` [PATCH 03/10] ftrace: allow building without frame pointers Rabin Vincent
2010-02-13 19:48   ` Rabin Vincent
2010-02-22 18:36   ` Frederic Weisbecker
2010-02-22 18:36     ` Frederic Weisbecker
2010-02-23 13:44   ` Steven Rostedt [this message]
2010-02-23 13:44     ` Steven Rostedt
2010-02-13 19:48 ` [PATCH 04/10] ARM: " Rabin Vincent
2010-02-13 19:48   ` Rabin Vincent
2010-02-22 19:05   ` Frederic Weisbecker
2010-02-22 19:05     ` Frederic Weisbecker
2010-02-23 13:18     ` Steven Rostedt
2010-02-23 13:18       ` Steven Rostedt
2010-02-23 17:11       ` Frederic Weisbecker
2010-02-23 17:11         ` Frederic Weisbecker
2010-02-23 17:58         ` Rabin Vincent
2010-02-23 17:58           ` Rabin Vincent
2010-02-23 18:03           ` Steven Rostedt
2010-02-23 18:03             ` Steven Rostedt
2010-02-23 18:41             ` Rabin Vincent
2010-02-23 18:41               ` Rabin Vincent
2010-02-23 13:47   ` Steven Rostedt
2010-02-23 13:47     ` Steven Rostedt
2010-02-13 19:48 ` [PATCH 05/10] ARM: ftrace: add ENDPROC annotations Rabin Vincent
2010-02-13 19:48   ` Rabin Vincent
2010-02-13 22:54   ` Catalin Marinas
2010-02-13 22:54     ` Catalin Marinas
2010-02-13 19:48 ` [PATCH 06/10] ARM: ftrace: add Thumb-2 support Rabin Vincent
2010-02-13 19:48   ` Rabin Vincent
2010-02-13 23:27   ` Catalin Marinas
2010-02-13 23:27     ` Catalin Marinas
2010-02-14 16:38     ` Rabin Vincent
2010-02-14 16:38       ` Rabin Vincent
2010-02-13 19:48 ` [PATCH 07/10] ftrace: pass KBUILD_CFLAGS to record_mcount.pl Rabin Vincent
2010-02-13 19:48   ` Rabin Vincent
2010-02-23 13:30   ` Steven Rostedt
2010-02-23 13:30     ` Steven Rostedt
2010-02-23 18:23     ` Rabin Vincent
2010-02-23 18:23       ` Rabin Vincent
2010-02-23 18:37       ` Steven Rostedt
2010-02-23 18:37         ` Steven Rostedt
2010-02-13 19:48 ` [PATCH 08/10] ARM: ftrace: fix and update dynamic ftrace Rabin Vincent
2010-02-13 19:48   ` Rabin Vincent
2010-02-14 11:08   ` Uwe Kleine-König
2010-02-14 11:08     ` Uwe Kleine-König
2010-02-14 15:53     ` Rabin Vincent
2010-02-14 15:53       ` Rabin Vincent
2010-02-13 19:48 ` [PATCH 09/10] ARM: ftrace: add Thumb-2 support to " Rabin Vincent
2010-02-13 19:48   ` Rabin Vincent
2010-02-23 13:35   ` Steven Rostedt
2010-02-23 13:35     ` Steven Rostedt
2010-02-23 17:10     ` Rabin Vincent
2010-02-23 17:10       ` Rabin Vincent
2010-02-13 19:48 ` [PATCH 10/10] ARM: ftrace: enable " Rabin Vincent
2010-02-13 19:48   ` Rabin Vincent
2010-02-22 18:16 ` [PATCH 00/10] ARM: ftrace: cleanups, Thumb-2, and " Rabin Vincent
2010-02-22 18:16   ` Rabin Vincent
  -- strict thread matches above, loose matches on Subject: below --
2010-03-13  6:49 [PATCH 00/10] ARM: ftrace: cleanups, Thumb-2, and dynamic ftrace (v2) Rabin Vincent
2010-03-13  6:49 ` [PATCH 03/10] ftrace: allow building without frame pointers Rabin Vincent
2010-03-13  6:49   ` Rabin Vincent
2010-03-13 17:36   ` Steven Rostedt
2010-03-13 17:36     ` Steven Rostedt
2010-03-15 18:45     ` Rabin Vincent
2010-03-15 18:45       ` Rabin Vincent
2010-03-14 16:56   ` Steven Rostedt
2010-03-14 16:56     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1266932682.19540.15.camel@frodo \
    --to=rostedt@goodmis.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.