* [PATCH] KVM: x86 emulator: fix unlocked CMPXCHG8B emulation.
@ 2010-03-21 14:58 Gleb Natapov
2010-03-23 12:34 ` Avi Kivity
0 siblings, 1 reply; 2+ messages in thread
From: Gleb Natapov @ 2010-03-21 14:58 UTC (permalink / raw)
To: avi, mtosatti; +Cc: kvm
When CMPXCHG8B is executed without LOCK prefix it is racy. Preserve this
behaviour in emulator too.
Signed-off-by: Gleb Natapov <gleb@redhat.com>
---
This patch goes on top of my previous "KVM: x86 emulator: add decoding
of CMPXCHG8B dst operand." patch.
diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index 904351e..e2bbb9c 100644
--- a/arch/x86/kvm/emulate.c
+++ b/arch/x86/kvm/emulate.c
@@ -1724,7 +1724,6 @@ static inline int emulate_grp9(struct x86_emulate_ctxt *ctxt,
(u32) c->regs[VCPU_REGS_RBX];
ctxt->eflags |= EFLG_ZF;
- c->lock_prefix = 1;
}
return X86EMUL_CONTINUE;
}
--
Gleb.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: x86 emulator: fix unlocked CMPXCHG8B emulation.
2010-03-21 14:58 [PATCH] KVM: x86 emulator: fix unlocked CMPXCHG8B emulation Gleb Natapov
@ 2010-03-23 12:34 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2010-03-23 12:34 UTC (permalink / raw)
To: Gleb Natapov; +Cc: mtosatti, kvm
On 03/21/2010 04:58 PM, Gleb Natapov wrote:
>
> When CMPXCHG8B is executed without LOCK prefix it is racy. Preserve this
> behaviour in emulator too.
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-23 12:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-21 14:58 [PATCH] KVM: x86 emulator: fix unlocked CMPXCHG8B emulation Gleb Natapov
2010-03-23 12:34 ` Avi Kivity
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.