From: "Michael S. Tsirkin" <mst@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Cam Macdonell <cam@cs.ualberta.ca>,
kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v3 1/1] Shared memory uio_pci driver
Date: Sun, 28 Mar 2010 12:40:06 +0300 [thread overview]
Message-ID: <20100328094006.GB21749@redhat.com> (raw)
In-Reply-To: <4BAF0D03.7060300@redhat.com>
On Sun, Mar 28, 2010 at 11:02:11AM +0300, Avi Kivity wrote:
> On 03/28/2010 10:47 AM, Michael S. Tsirkin wrote:
>>>
>>>> Maybe irqcontrol could be extended?
>>>>
>>>>
>>> What's irqcontrol?
>>>
>> uio accepts 32 bit writes to the char device file. We can encode
>> the fd number there, and use the high bit to signal assign/deassign.
>>
>
> Ugh. Very unexpandable.
It currently fails on any non-4 byte write.
So if we need more bits in the future we can always teach it
about e.g. 8 byte writes.
Do you think it's worth it doing it now already, and using
8 byte writes for msi mapping?
> --
> error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Cam Macdonell <cam@cs.ualberta.ca>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] Re: [PATCH v3 1/1] Shared memory uio_pci driver
Date: Sun, 28 Mar 2010 12:40:06 +0300 [thread overview]
Message-ID: <20100328094006.GB21749@redhat.com> (raw)
In-Reply-To: <4BAF0D03.7060300@redhat.com>
On Sun, Mar 28, 2010 at 11:02:11AM +0300, Avi Kivity wrote:
> On 03/28/2010 10:47 AM, Michael S. Tsirkin wrote:
>>>
>>>> Maybe irqcontrol could be extended?
>>>>
>>>>
>>> What's irqcontrol?
>>>
>> uio accepts 32 bit writes to the char device file. We can encode
>> the fd number there, and use the high bit to signal assign/deassign.
>>
>
> Ugh. Very unexpandable.
It currently fails on any non-4 byte write.
So if we need more bits in the future we can always teach it
about e.g. 8 byte writes.
Do you think it's worth it doing it now already, and using
8 byte writes for msi mapping?
> --
> error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-03-28 9:43 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 6:09 [PATCH v3 1/1] Shared memory uio_pci driver Cam Macdonell
2010-03-25 6:09 ` [Qemu-devel] " Cam Macdonell
2010-03-25 9:05 ` Michael S. Tsirkin
2010-03-25 9:05 ` [Qemu-devel] " Michael S. Tsirkin
2010-03-25 9:47 ` Avi Kivity
2010-03-25 9:47 ` [Qemu-devel] " Avi Kivity
2010-03-25 16:30 ` Cam Macdonell
2010-03-25 16:30 ` [Qemu-devel] " Cam Macdonell
2010-03-25 16:34 ` Michael S. Tsirkin
2010-03-25 16:34 ` [Qemu-devel] " Michael S. Tsirkin
2010-03-25 17:07 ` Cam Macdonell
2010-03-25 17:07 ` [Qemu-devel] " Cam Macdonell
2010-03-25 16:36 ` Avi Kivity
2010-03-25 16:36 ` [Qemu-devel] " Avi Kivity
2010-03-25 16:37 ` Michael S. Tsirkin
2010-03-25 16:37 ` [Qemu-devel] " Michael S. Tsirkin
2010-03-25 16:51 ` Avi Kivity
2010-03-25 16:51 ` [Qemu-devel] " Avi Kivity
2010-03-25 9:15 ` Michael S. Tsirkin
2010-03-25 9:15 ` [Qemu-devel] " Michael S. Tsirkin
2010-03-25 9:40 ` Avi Kivity
2010-03-25 9:40 ` [Qemu-devel] " Avi Kivity
2010-03-25 9:44 ` Michael S. Tsirkin
2010-03-25 9:44 ` Michael S. Tsirkin
2010-03-25 9:44 ` [Qemu-devel] " Michael S. Tsirkin
2010-03-25 9:58 ` Avi Kivity
2010-03-25 9:58 ` [Qemu-devel] " Avi Kivity
2010-03-25 10:07 ` Michael S. Tsirkin
2010-03-25 10:07 ` Michael S. Tsirkin
2010-03-25 10:07 ` [Qemu-devel] " Michael S. Tsirkin
2010-03-25 9:58 ` Avi Kivity
2010-03-25 9:40 ` Avi Kivity
2010-03-25 16:18 ` Cam Macdonell
2010-03-25 16:18 ` [Qemu-devel] " Cam Macdonell
2010-03-25 16:23 ` Anthony Liguori
2010-03-25 16:23 ` Anthony Liguori
2010-03-25 16:23 ` [Qemu-devel] " Anthony Liguori
2010-03-25 16:32 ` Avi Kivity
2010-03-25 16:32 ` Avi Kivity
2010-03-25 16:32 ` [Qemu-devel] " Avi Kivity
2010-03-25 16:40 ` Michael S. Tsirkin
2010-03-25 16:40 ` Michael S. Tsirkin
2010-03-25 16:40 ` [Qemu-devel] " Michael S. Tsirkin
2010-03-25 16:50 ` Avi Kivity
2010-03-25 16:50 ` Avi Kivity
2010-03-25 16:50 ` [Qemu-devel] " Avi Kivity
2010-03-25 16:33 ` Michael S. Tsirkin
2010-03-25 16:33 ` [Qemu-devel] " Michael S. Tsirkin
2010-03-25 16:33 ` Michael S. Tsirkin
2010-03-25 16:18 ` Cam Macdonell
2010-03-25 9:15 ` Michael S. Tsirkin
2010-03-25 9:46 ` Avi Kivity
2010-03-25 9:46 ` [Qemu-devel] " Avi Kivity
2010-03-25 16:24 ` Cam Macdonell
2010-03-25 16:24 ` [Qemu-devel] " Cam Macdonell
2010-03-25 16:35 ` Avi Kivity
2010-03-25 16:35 ` [Qemu-devel] " Avi Kivity
2010-03-26 16:14 ` Cam Macdonell
2010-03-26 16:14 ` [Qemu-devel] " Cam Macdonell
2010-03-27 17:48 ` Avi Kivity
2010-03-27 17:48 ` [Qemu-devel] " Avi Kivity
2010-03-28 7:47 ` Michael S. Tsirkin
2010-03-28 7:47 ` [Qemu-devel] " Michael S. Tsirkin
2010-03-28 8:02 ` Avi Kivity
2010-03-28 8:02 ` [Qemu-devel] " Avi Kivity
2010-03-28 9:40 ` Michael S. Tsirkin [this message]
2010-03-28 9:40 ` Michael S. Tsirkin
2010-03-28 9:45 ` Avi Kivity
2010-03-28 9:45 ` [Qemu-devel] " Avi Kivity
2010-03-28 10:31 ` Michael S. Tsirkin
2010-03-28 10:31 ` [Qemu-devel] " Michael S. Tsirkin
2010-03-28 11:12 ` Avi Kivity
2010-03-28 11:12 ` [Qemu-devel] " Avi Kivity
2010-03-28 13:28 ` Jamie Lokier
2010-03-28 13:28 ` Jamie Lokier
2010-03-28 13:47 ` malc
2010-03-28 13:47 ` malc
2010-03-28 19:48 ` Cam Macdonell
2010-03-28 19:48 ` [Qemu-devel] " Cam Macdonell
2010-03-29 20:59 ` Avi Kivity
2010-03-29 20:59 ` [Qemu-devel] " Avi Kivity
2010-03-30 14:52 ` Cam Macdonell
2010-03-30 14:52 ` [Qemu-devel] " Cam Macdonell
2010-04-01 8:59 ` Avi Kivity
2010-04-01 8:59 ` [Qemu-devel] " Avi Kivity
2010-03-31 9:12 ` Michael S. Tsirkin
2010-03-31 9:12 ` [Qemu-devel] " Michael S. Tsirkin
2010-04-01 8:58 ` Avi Kivity
2010-04-01 8:58 ` [Qemu-devel] " Avi Kivity
2010-04-01 10:59 ` Michael S. Tsirkin
2010-04-01 10:59 ` [Qemu-devel] " Michael S. Tsirkin
2010-04-01 11:27 ` Avi Kivity
2010-04-01 11:27 ` [Qemu-devel] " Avi Kivity
2010-03-25 16:42 ` Michael S. Tsirkin
2010-03-25 16:42 ` [Qemu-devel] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100328094006.GB21749@redhat.com \
--to=mst@redhat.com \
--cc=avi@redhat.com \
--cc=cam@cs.ualberta.ca \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.