All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Jean Delvare <khali@linux-fr.org>
Cc: linux-acpi@vger.kernel.org,
	LM Sensors <lm-sensors@lm-sensors.org>,
	Len Brown <lenb@kernel.org>
Subject: Re: [PATCH] hwmon: (asus_atk0110) Don't load if ACPI  resources aren't enforced
Date: Tue, 30 Mar 2010 22:10:49 +0100	[thread overview]
Message-ID: <20100330211049.GA1524@srcf.ucam.org> (raw)
In-Reply-To: <20100330223251.76c6b000@hyperion.delvare>

On Tue, Mar 30, 2010 at 10:32:51PM +0200, Jean Delvare wrote:

> Sure, but why do you insist on having the user configure this manually
> when we can automate this at the kernel level? When
> acpi_enforce_resouce=yes, the kernel doesn't let non-ACPI driver be
> loaded, so I fail to see why we let ACPI drivers (for which we also
> have native drivers) load when acpi_enforce_resouce=no.

Because the situation with the asus driver loaded isn't obviously any 
worse than not having it loaded. The user is telling us that they're 
happy with racy access to their hwmon hardware. Automatically blocking 
the loading of the ACPI driver does nothing other than imply to the user 
that things are safe, when in reality they're anything but.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

WARNING: multiple messages have this Message-ID (diff)
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Jean Delvare <khali@linux-fr.org>
Cc: linux-acpi@vger.kernel.org,
	LM Sensors <lm-sensors@lm-sensors.org>,
	Len Brown <lenb@kernel.org>
Subject: Re: [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI
Date: Tue, 30 Mar 2010 21:10:49 +0000	[thread overview]
Message-ID: <20100330211049.GA1524@srcf.ucam.org> (raw)
In-Reply-To: <20100330223251.76c6b000@hyperion.delvare>

On Tue, Mar 30, 2010 at 10:32:51PM +0200, Jean Delvare wrote:

> Sure, but why do you insist on having the user configure this manually
> when we can automate this at the kernel level? When
> acpi_enforce_resouce=yes, the kernel doesn't let non-ACPI driver be
> loaded, so I fail to see why we let ACPI drivers (for which we also
> have native drivers) load when acpi_enforce_resouce=no.

Because the situation with the asus driver loaded isn't obviously any 
worse than not having it loaded. The user is telling us that they're 
happy with racy access to their hwmon hardware. Automatically blocking 
the loading of the ACPI driver does nothing other than imply to the user 
that things are safe, when in reality they're anything but.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2010-03-30 21:10 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-09 12:56 [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI Jean Delvare
2010-03-09 20:20 ` Luca Tettamanti
2010-03-30 10:03 ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Jean Delvare
2010-03-30 10:03   ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI Jean Delvare
2010-03-30 13:21   ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Matthew Garrett
2010-03-30 13:21     ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if Matthew Garrett
2010-03-30 19:47     ` [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Jean Delvare
2010-03-30 19:47       ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI Jean Delvare
2010-03-30 19:48       ` [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Matthew Garrett
2010-03-30 19:48         ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI Matthew Garrett
2010-03-30 20:32         ` [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Jean Delvare
2010-03-30 20:32           ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI Jean Delvare
2010-03-30 21:10           ` Matthew Garrett [this message]
2010-03-30 21:10             ` Matthew Garrett
2010-03-30 21:45             ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Luca Tettamanti
2010-03-30 21:45               ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI Luca Tettamanti
2010-03-30 21:53               ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Matthew Garrett
2010-03-30 21:53                 ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if Matthew Garrett
2010-03-31  7:30                 ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Jean Delvare
2010-03-31  7:30                   ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI Jean Delvare
2010-03-31 12:51                   ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Matthew Garrett
2010-03-31 12:51                     ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if Matthew Garrett
2010-03-31 13:25                     ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Jean Delvare
2010-03-31 13:25                       ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI Jean Delvare
2010-03-31 13:27                       ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Matthew Garrett
2010-03-31 13:27                         ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if Matthew Garrett
2010-03-31 13:37                         ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Jean Delvare
2010-03-31 13:37                           ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI Jean Delvare
2010-03-31  7:42             ` [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Jean Delvare
2010-03-31  7:42               ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100330211049.GA1524@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=khali@linux-fr.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.