From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Jean Delvare <khali@linux-fr.org>
Cc: Luca Tettamanti <kronos.it@gmail.com>,
linux-acpi@vger.kernel.org, Len Brown <lenb@kernel.org>,
LM Sensors <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced
Date: Wed, 31 Mar 2010 14:27:11 +0100 [thread overview]
Message-ID: <20100331132711.GA17104@srcf.ucam.org> (raw)
In-Reply-To: <20100331152500.4b2ef6a0@hyperion.delvare>
On Wed, Mar 31, 2010 at 03:25:00PM +0200, Jean Delvare wrote:
> On Wed, 31 Mar 2010 13:51:23 +0100, Matthew Garrett wrote:
> > On Wed, Mar 31, 2010 at 09:30:04AM +0200, Jean Delvare wrote:
> >
> > > It definitely does. At least on some of the affected boards, no access
> > > to the I/O area in question is done at all as long as the asus_atk0110
> > > driver is not loaded.
> >
> > You've audited the system management code?
>
> No, I did not. But you did not review the system management code of all
> computers out there either, and you are still writing kernel code that
> could be broken by it. So what's the point?
If the firmware tells us that a resource range using indexed access is
reserved, it's not safe to assume that the firmware isn't using it.
--
Matthew Garrett | mjg59@srcf.ucam.org
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Jean Delvare <khali@linux-fr.org>
Cc: Luca Tettamanti <kronos.it@gmail.com>,
linux-acpi@vger.kernel.org, Len Brown <lenb@kernel.org>,
LM Sensors <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if
Date: Wed, 31 Mar 2010 13:27:11 +0000 [thread overview]
Message-ID: <20100331132711.GA17104@srcf.ucam.org> (raw)
In-Reply-To: <20100331152500.4b2ef6a0@hyperion.delvare>
On Wed, Mar 31, 2010 at 03:25:00PM +0200, Jean Delvare wrote:
> On Wed, 31 Mar 2010 13:51:23 +0100, Matthew Garrett wrote:
> > On Wed, Mar 31, 2010 at 09:30:04AM +0200, Jean Delvare wrote:
> >
> > > It definitely does. At least on some of the affected boards, no access
> > > to the I/O area in question is done at all as long as the asus_atk0110
> > > driver is not loaded.
> >
> > You've audited the system management code?
>
> No, I did not. But you did not review the system management code of all
> computers out there either, and you are still writing kernel code that
> could be broken by it. So what's the point?
If the firmware tells us that a resource range using indexed access is
reserved, it's not safe to assume that the firmware isn't using it.
--
Matthew Garrett | mjg59@srcf.ucam.org
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2010-03-31 13:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 12:56 [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI Jean Delvare
2010-03-09 20:20 ` Luca Tettamanti
2010-03-30 10:03 ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Jean Delvare
2010-03-30 10:03 ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI Jean Delvare
2010-03-30 13:21 ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Matthew Garrett
2010-03-30 13:21 ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if Matthew Garrett
2010-03-30 19:47 ` [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Jean Delvare
2010-03-30 19:47 ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI Jean Delvare
2010-03-30 19:48 ` [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Matthew Garrett
2010-03-30 19:48 ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI Matthew Garrett
2010-03-30 20:32 ` [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Jean Delvare
2010-03-30 20:32 ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI Jean Delvare
2010-03-30 21:10 ` [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Matthew Garrett
2010-03-30 21:10 ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI Matthew Garrett
2010-03-30 21:45 ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Luca Tettamanti
2010-03-30 21:45 ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI Luca Tettamanti
2010-03-30 21:53 ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Matthew Garrett
2010-03-30 21:53 ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if Matthew Garrett
2010-03-31 7:30 ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Jean Delvare
2010-03-31 7:30 ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI Jean Delvare
2010-03-31 12:51 ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Matthew Garrett
2010-03-31 12:51 ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if Matthew Garrett
2010-03-31 13:25 ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Jean Delvare
2010-03-31 13:25 ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI Jean Delvare
2010-03-31 13:27 ` Matthew Garrett [this message]
2010-03-31 13:27 ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if Matthew Garrett
2010-03-31 13:37 ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Jean Delvare
2010-03-31 13:37 ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI Jean Delvare
2010-03-31 7:42 ` [PATCH] hwmon: (asus_atk0110) Don't load if ACPI resources aren't enforced Jean Delvare
2010-03-31 7:42 ` [lm-sensors] [PATCH] hwmon: (asus_atk0110) Don't load if ACPI Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100331132711.GA17104@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=khali@linux-fr.org \
--cc=kronos.it@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.